Merge lp:~sinzui/launchpad/entitle-branch-sharing into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 15846 |
Proposed branch: | lp:~sinzui/launchpad/entitle-branch-sharing |
Merge into: | lp:launchpad |
Prerequisite: | lp:~sinzui/launchpad/project-branch-permissions |
Diff against target: |
473 lines (+27/-99) 13 files modified
lib/lp/bugs/browser/tests/test_bugs.py (+2/-6) lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+4/-10) lib/lp/bugs/mail/tests/test_handler.py (+2/-4) lib/lp/bugs/tests/test_bugs_webservice.py (+1/-5) lib/lp/code/browser/tests/test_branch.py (+4/-8) lib/lp/code/browser/tests/test_branchlisting.py (+3/-3) lib/lp/code/model/tests/test_branch.py (+4/-8) lib/lp/code/model/tests/test_branchnamespace.py (+1/-4) lib/lp/registry/model/product.py (+0/-8) lib/lp/registry/tests/test_product.py (+1/-4) lib/lp/registry/tests/test_product_webservice.py (+2/-32) lib/lp/soyuz/tests/test_archive.py (+3/-4) lib/lp/testing/sampledata.py (+0/-3) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/entitle-branch-sharing |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant (community) | code | Approve | |
Review via email:
|
Commit message
Allow project maintainers to call setBranchSharin
Description of the change
Launchpad must let users reconfigure their projects to use sharing
which enters beta next week.
-------
RULES
Pre-
* Remove the guard in setBranchSharin
deprecated rule that restricts branch policies to be set by a
commercial admin.
* Simplify tests that use a commmercial admin to setup the conditions.
QA
As a non-commercial admin
* Visit http://
* Verify you can change the branch sharing policy.
LINT
lib/
lib/
lib/
lib/
TEST
./bin/test -vvc -t transitionToInf
./bin/test -vvc -t WithInformationType lp.code.
./bin/test -vvc -t EditViewInforma
IMPLEMENTATION
Remove the commerncial admin guard from setBranchSharin
lib/
Update tests to use the project owner instead of a commecial admin to
setup the test conditions.
lib/
lib/
lib/
This can't land before <https:/ /code.launchpad .net/~sinzui/ launchpad/ commercial- admin-sharing/ +merge/ 120464>, as in this branch there's no access check at all on setBugSharingPolicy or setBranchSharin gPolicy. If your new permission from the other branch is sufficient, perhaps remove the unused user argument from setFooSharingPo licy.