Merge lp:~sinzui/launchpad/do-not-release into lp:launchpad

[Curtis Hovey]

This is my branch to not release suggest project packages portlet.

    lp:~sinzui/launchpad/do-not-release
    Diff size:
    Launchpad bug: https://bugs.launchpad.net/bugs/548822
    Test command: ./bin/test -vv \
        -t product-portlet-packages-view \
        -t xx-product-index
    Pre-implementation: no one
    Target release: 10.03

not release suggest project packages portlet
--------------------------------------------------------------------

The portlet that suggests packages that a project provides should not be
visible to general users because it is not yet possible to say that the
project does not provide any packages.

Rules
-----

    * The portlet should only be visible on dev, staging and edge.
    * Bonus: Do not show obsolete packages and limit the number to the
      5 most recent.

QA
--

    * Visit /gdp on edge and staging and verify the packages portlet
      suggests packages
    * Visit lp.net and verify /gdp does not suggest packages.
    * Visit /bzr and verify that every package has an upload time and that
      there are fix of them.

Lint
----

Linting changed files:
  lib/lp/registry/browser/product.py
  lib/lp/registry/browser/tests/product-portlet-packages-view.txt
  lib/lp/registry/stories/product/xx-product-index.txt
  lib/lp/registry/templates/product-portlet-packages.pt

Test
----

    * lib/lp/registry/browser/tests/product-portlet-packages-view.txt
      * Added a test for sourcepackages and can_show_portlet
    * lib/lp/registry/stories/product/xx-product-index.txt
      * Updated the test to verify that obsolete packages are not shown.

Implementation
--------------

    * lib/lp/registry/browser/product.py
      * Added a property to test if the portlet should be shown.
        This property will continue to be used after development. In the
        future it will replace the lpnet check with a check for a confirmation
        that the project is already known not to be packaged.
      * Add a property to filter the obsolete sourcepackages and limit them
        to 5.
    * lib/lp/registry/templates/product-portlet-packages.pt
      * Updated the template to use the two properties.

[Edwin Grubbs (edwin-grubbs)]

Looks good.

review: Approve (code)

=== modified file 'lib/lp/registry/browser/product.py'
--- lib/lp/registry/browser/product.py	2010-03-23 15:35:39 +0000
+++ lib/lp/registry/browser/product.py	2010-03-26 17:36:44 +0000
@@ -452,7 +452,7 @@
         'bugsupervisor',
         'securitycontact',
         'cve',
-        'subscribe'
+        'subscribe',
         )
 
     def filebug(self):
@@ -978,6 +978,20 @@
         orientation='vertical')
     suggestions = None
 
+    @cachedproperty
+    def sourcepackages(self):
+        """The project's latest source packages."""
+        current_packages = [
+            sp for sp in self.context.sourcepackages
+            if sp.currentrelease is not None]
+        current_packages.reverse()
+        return current_packages[0:5]
+
+    @cachedproperty
+    def can_show_portlet(self):
+        """Are there packages, or can packages be suggested."""
+        return len(self.sourcepackages) > 0 or not config.launchpad.is_lpnet
+
     def setUpFields(self):
         """See `LaunchpadFormView`."""
         super(ProductPackagesPortletView, self).setUpFields()
@@ -1341,6 +1355,7 @@
         # supervisor.
         self.validate_private_bugs(data)
 
+
 class ProductAddSeriesView(LaunchpadFormView):
     """A form to add new product series"""
 
@@ -1742,8 +1757,7 @@
             description=description,
             licenses=data['licenses'],
             license_info=data['license_info'],
-            project=project
-            )
+            project=project)
 
     def main_action(self, data):
         """See `MultiStepView`."""

=== modified file 'lib/lp/registry/browser/tests/product-portlet-packages-view.txt'
--- lib/lp/registry/browser/tests/product-portlet-packages-view.txt	2010-03-23 14:52:14 +0000
+++ lib/lp/registry/browser/tests/product-portlet-packages-view.txt	2010-03-26 17:36:44 +0000
@@ -61,7 +61,8 @@
     provides. Links from distribution packages to upstream projects
     let distribution and upstream maintainers share bugs, patches, and
     translations efficiently.
-    There are no unlinked source packages that are a good match. Can you suggest one?
+    There are no unlinked source packages that are a good match. Can you
+    suggest one?
     Link to Ubuntu package
 
 
@@ -182,3 +183,75 @@
     >>> for dsp in view.suggestions:
     ...     print dsp.name
     bingo
+
+The can_show_portlet property indicates that the portlet can be rendered. The
+portlet is not rendered if there are no source packages and the environment
+is lpnet.
+
+    >>> config.launchpad.is_lpnet
+    False
+
+    >>> view.sourcepackages
+    []
+
+    >>> view.can_show_portlet
+    True
+
+    >>> print extract_text(view.render())
+    All packages
+    Packages in Ubuntu ...
+
+    >>> test_data = """
+    ...     [launchpad]
+    ...     is_lpnet: True
+    ...     """
+    >>> config.push('test_data', test_data)
+    >>> config.launchpad.is_lpnet
+    True
+
+    >>> view = create_initialized_view(
+    ...     product, name="+portlet-packages", principal=product.owner)
+    >>> view.can_show_portlet
+    False
+
+    >>> print extract_text(view.render())
+    <BLANKLINE>
+
+    >>> ignore = config.pop('test_data')
+
+The view's sourcepackages property filters out obsolete packages and
+reverses the order so that the latest packages for the current ubuntu
+series are shown first.
+
+    >>> from lp.registry.interfaces.packaging import (
+    ...     IPackagingUtil, PackagingType)
+
+    >>> packaging_util = getUtility(IPackagingUtil)
+    >>> series = ubuntu.currentseries
+    >>> spn = factory.makeSourcePackageName(name="a-obsolete-package")
+    >>> packaging_util.createPackaging(
+    ...     product.development_focus, spn, ubuntu.currentseries,
+    ...     PackagingType.PRIME, owner=product.owner)
+    >>> spn = factory.makeSourcePackageName(name="b-recent-package")
+    >>> spph = factory.makeSourcePackagePublishingHistory(
+    ...     sourcepackagename=spn, distroseries=ubuntu.currentseries)
+    >>> packaging_util.createPackaging(
+    ...     product.development_focus, spn, ubuntu.currentseries,
+    ...     PackagingType.PRIME, owner=product.owner)
+    >>> spn = factory.makeSourcePackageName(name="c-current-package")
+    >>> spph = factory.makeSourcePackagePublishingHistory(
+    ...     sourcepackagename=spn, distroseries=ubuntu.currentseries)
+    >>> packaging_util.createPackaging(
+    ...     product.development_focus, spn, ubuntu.currentseries,
+    ...     PackagingType.PRIME, owner=product.owner)
+    >>> for package in product.sourcepackages:
+    ...     print package.name
+    a-obsolete-package
+    b-recent-package
+    c-current-package
+
+    >>> view = create_initialized_view(product, name="+portlet-packages")
+    >>> for package in view.sourcepackages:
+    ...     print package.name
+    c-current-package
+    b-recent-package

=== modified file 'lib/lp/registry/stories/product/xx-product-index.txt'
--- lib/lp/registry/stories/product/xx-product-index.txt	2010-03-09 01:45:05 +0000
+++ lib/lp/registry/stories/product/xx-product-index.txt	2010-03-26 17:36:44 +0000
@@ -360,7 +360,6 @@
     ...     find_tag_by_id(user_browser.contents, 'portlet-packages'))
     All packages
     Packages in Ubuntu
-    “mozilla-firefox” source package in Hoary
     “mozilla-firefox” source package in Warty Version 0.9 uploaded on...
 
 A product that has linked packages now displays suggestions and asks

=== modified file 'lib/lp/registry/templates/product-portlet-packages.pt'
--- lib/lp/registry/templates/product-portlet-packages.pt	2010-03-08 19:42:11 +0000
+++ lib/lp/registry/templates/product-portlet-packages.pt	2010-03-26 17:36:44 +0000
@@ -3,7 +3,8 @@
   xmlns:metal="http://xml.zope.org/namespaces/metal"
   xmlns:i18n="http://xml.zope.org/namespaces/i18n"
   omit-tag=""
-  define="packages context/sourcepackages">
+  define="packages view/sourcepackages"
+  condition="view/can_show_portlet">
 
 <div class="portlet" id="portlet-packages">
   <h2>