Merge lp:~sinzui/launchpad/css-ui-1 into lp:launchpad
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 12103 | ||||||||
Proposed branch: | lp:~sinzui/launchpad/css-ui-1 | ||||||||
Merge into: | lp:launchpad | ||||||||
Diff against target: |
814 lines (+178/-162) 16 files modified
lib/canonical/launchpad/icing/style-3-0.css.in (+20/-10) lib/canonical/launchpad/icing/style.css (+0/-19) lib/canonical/launchpad/webapp/error.py (+1/-1) lib/lp/answers/stories/project-add-question.txt (+105/-90) lib/lp/answers/stories/questions-index.txt (+3/-3) lib/lp/answers/templates/question-listing-detailed.pt (+2/-2) lib/lp/registry/browser/distribution.py (+5/-4) lib/lp/registry/browser/product.py (+5/-4) lib/lp/registry/browser/tests/distribution-views.txt (+4/-4) lib/lp/registry/stories/distributionmirror/xx-distribution-mirrors.txt (+18/-10) lib/lp/registry/stories/productseries/xx-productseries-series.txt (+4/-4) lib/lp/registry/templates/distributionmirror-macros.pt (+3/-3) lib/lp/registry/templates/productreleasefile-macros.pt (+1/-1) lib/lp/registry/templates/team-editproposed.pt (+2/-2) lib/lp/soyuz/browser/sourcepackagerelease.py (+1/-1) lib/lp/soyuz/browser/tests/test_sourcepackagerelease.py (+4/-4) |
||||||||
To merge this branch: | bzr merge lp:~sinzui/launchpad/css-ui-1 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+44068@code.launchpad.net |
Description of the change
Clean up the CSS.
Launchpad bug:
https:/
https:/
Pre-
Test command: ./bin/test -vv \
-t distribution-views -t xx-productserie
Bug #90502 [class="highlight" and class="highlighted" shouldn't coexist]
* Both classes use the base rules. There should be only one.
The 3.0 eliminated most of the highlighted cases. polls are being
removed, so distro mirrors are the only case
Bug #415267 [Table header cells should not be centered]
ages with wide tables but narrow data, such as
<https:/
I made in designing Launchpad tables: the text in table header cells
should not be centered.
-------
RULES
Bug #90502 [class="highlight" and class="highlighted" shouldn't coexist]
* update distributionmir
highlighted
* Remove the highligted rules from the CSS.
* Rename dimmed to lowlight.
Bug #415267 [Table header cells should not be centered]
* use text-align: left so that the left edge of the text in the th
aligns with the text in the td.
QA
Bug #90502 [class="highlight" and class="highlighted" shouldn't coexist]
* Visit https:/
* Verify the country and total are highlighted.
Bug #415267 [Table header cells should not be centered]
* Visit any table listing in lp and verify that the table headers
have left-aligned text.
LINT
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
IMPLEMENTATION
Bug #90502 [class="highlight" and class="highlighted" shouldn't coexist]
Update template to use highlight and removed highligted from css.
Removed unhighlighted. Renamed dimmed to lowlight. Removed .series
class because the rules are always superseded by other css rules.
lib/
lib/
lib/
lib/
lib/
lib/
lib/
Bug #415267 [Table header cells should not be centered]
Updated the style as mpt suggested.
lib/
The changes look good Curtis. But if I grep for 'class= "highlighted" ' I get six hits:
bzr ls -VR --kind=file --null | xargs -0 grep -In class\= \"highlighted\ " launchpad/ webapp/ error.py: 118: return ('<div class="highlighted" style="' soyuz/browser/ sourcepackagere lease.py: 158: highlight = r'<span class=" highlighted" >\1</span> ' soyuz/browser/ tests/test_ sourcepackagere lease.py: 90: '<span class=" highlighted" >https:/ /upstream. dom/fnord/ no/</span> ' soyuz/browser/ tests/test_ sourcepackagere lease.py: 102: '<span class=" highlighted" >/usr/share/ common- licenses/ GPL</span> ') soyuz/browser/ tests/test_ sourcepackagere lease.py: 113: '<span class=" highlighted" >/usr/share/ common- licenses/ GPL</span> ' soyuz/browser/ tests/test_ sourcepackagere lease.py: 114: 'or <span class=" highlighted" >https:/ /osi.org/ mit</span>')
lib/canonical/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/