Merge lp:~sinzui/launchpad/conjoined-shortlist-0 into lp:launchpad

[Curtis Hovey]

Increase the shortlist size for conjoined bugs.

    Launchpad bug: https://bugs.launchpad.net/bugs/226535
    Pre-implementation: lifeless
    Test: ./bin/test -vvc -t doc/bugtask.txt -t doc/bugwatch.txt

There are oopses involving about 100 pathological bugs that have more than
15 bug tasks. The conjoined code uses shortlist and we see
    UserWarning: shortlist() should not be used here.

We *do* want to use shortlist. Launchpad does not restrict bugtasks, nor
does it allow users to delete them--bugs *are* allowed to have more than
15. Lp does not have an issue working with these pathological cases, so
the shortlist can be increased.

--------------------------------------------------------------------

RULES

    * Set the shortlist size to 200 to accommodate the bugs.

QA

    * Visit https://bugs.launchpad.net/ubuntu/+source/pgadmin3/+bug/610975
    * Verify it displays.

LINT

    lib/lp/bugs/model/bugtask.py

IMPLEMENTATION

Extracted the shortlist calls to a private method. Updated the call to
pass longest_expected=200.
    lib/lp/bugs/model/bugtask.py

[Curtis Hovey (sinzui)]

Self approve.

review: Approve (code)

=== modified file 'lib/lp/bugs/model/bugtask.py'
--- lib/lp/bugs/model/bugtask.py	2011-02-27 19:45:44 +0000
+++ lib/lp/bugs/model/bugtask.py	2011-03-03 16:58:24 +0000
@@ -759,10 +759,13 @@
             conjoined_master = None
         return conjoined_master
 
+    def _get_shortlisted_bugtasks(self):
+        return shortlist(self.bug.bugtasks, longest_expected=200)
+
     @property
     def conjoined_master(self):
         """See `IBugTask`."""
-        return self.getConjoinedMaster(shortlist(self.bug.bugtasks))
+        return self.getConjoinedMaster(self._get_shortlisted_bugtasks())
 
     @property
     def conjoined_slave(self):
@@ -773,7 +776,7 @@
             if self.distroseries != distribution.currentseries:
                 # Only current series tasks are conjoined.
                 return None
-            for bugtask in shortlist(self.bug.bugtasks):
+            for bugtask in self._get_shortlisted_bugtasks():
                 if (bugtask.distribution == distribution and
                     bugtask.sourcepackagename == self.sourcepackagename):
                     conjoined_slave = bugtask
@@ -783,7 +786,7 @@
             if self.productseries != product.development_focus:
                 # Only development focus tasks are conjoined.
                 return None
-            for bugtask in shortlist(self.bug.bugtasks):
+            for bugtask in self._get_shortlisted_bugtasks():
                 if bugtask.product == product:
                     conjoined_slave = bugtask
                     break