Merge lp:~sinzui/launchpad/bug-contacts-2 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Edwin Grubbs |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10950 |
Proposed branch: | lp:~sinzui/launchpad/bug-contacts-2 |
Merge into: | lp:launchpad |
Diff against target: |
295 lines (+185/-8) 4 files modified
lib/lp/bugs/browser/bugtarget.py (+46/-3) lib/lp/bugs/browser/configure.zcml (+4/-0) lib/lp/bugs/browser/tests/test_bugtarget_configure.py (+123/-0) lib/lp/bugs/browser/tests/test_views.py (+12/-5) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/bug-contacts-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Jelmer Vernooij (community) | code* | Abstain | |
Review via email: mp+26093@code.launchpad.net |
Description of the change
This is my branch to add bug roles to +configure-bugs.
lp:~sinzui/launchpad/bug-contacts-2
Diff size: 295
Launchpad bug: https:/
Test command: ./bin/test -vv \
-t test_bugtarget_
Pre-
Target release: 10.05
Add bug roles to +configure-bugs
-------
Add the bug supervisor and security contact roles to +configure-bugs
Rules
-----
* Compose an interface that provides all the bug configuration fields.
* Reuse the security contact and bug supervisor validation and
transition rules.
QA
--
* Visit https:/
* Chose configure bugs
* Verify you can set the bug supervisor and security contact roles.
Lint
----
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Test
----
* lib/lp/
* Added a unittest to verify the form additions.
* The enable_
tests in stories. I expect these will be moved or expanded upon
in a subsequent branch that moves the field into the bugtracker
widget.
Implementation
--------------
* lib/lp/
* Composed an interface to represent the form schema.
* Created an adapter to allow IProduct work with the schema.
* Extended the existing form to use the composed schema. The form
also reuses bug supervisor and security contact validation and
change rules.
* lib/lp/
* Registered the adapter for IProduct.
* lib/lp/
* Change the default test layer to DatabaseFunctio
I wanted my tests to run faster.
This seems right to me, tests all work and style-wise it's fine but I don't think I'm familiar enough with the code to be able to approve this. Michael (my review mentor) is also out at the moment so he can't review me. Can somebody else have a look?