Merge lp:~sinzui/launchpad/ask-question-from-bug into lp:launchpad

[Curtis Hovey]

Disable ask/convert to question in Bugs when the project does not use Answers.

    Launchpad bug: https://bugs.launchpad.net/bugs/860565
    Pre-implementation: No one

If some project has not enabled answers then user still can ask questions
clicking on Bugs tab using the "Ask a question" link.

I saw this bug reported and knew it could be fixed in a few minutes. I also
realised that the convert to question rules probably ignored Answers too.

--------------------------------------------------------------------

RULES

    * Update the view to return None for the addquestion URL when the
      pillar does not use Answers.
    * Update the canBeAQuestion() method to check that the pillar uses
      answers.

QA

    * Visit https://bugs.qastaging.launchpad.net/bzr-tiplog
    * Verify "Ask a question" is not an action in the side bar.
    * Visit any bug with only one task
    * Verify the "Convert to question" action is not in the side bar.

LINT

    lib/lp/bugs/browser/bugtask.py
    lib/lp/bugs/browser/tests/test_buglisting.py
    lib/lp/bugs/model/bug.py
    lib/lp/bugs/tests/bugtarget-questiontarget.txt
    lib/lp/bugs/tests/test_bugtarget.py

TEST

    ./bin/test -vvc -t TestBugTaskSearchListingViewProduct \
        lp.bugs.browser.tests.test_buglisting
    ./bin/test -vvc lp.bugs.tests.test_bugtarget

IMPLEMENTATION

Return None for in addquestion_url() when the pillar does not use Answers.
    lib/lp/bugs/browser/bugtask.py
    lib/lp/bugs/browser/tests/test_buglisting.py

Return False for in canBeAQuestion() when the pillar does not use Answers.
Adding a new test to bugtarget-questiontarget.txt broke the mail checks in
the test. I decided to replace the section in the doctest with a unittest.
    lib/lp/bugs/model/bug.py
    lib/lp/bugs/tests/bugtarget-questiontarget.txt
    lib/lp/bugs/tests/test_bugtarget.py

[j.c.sackett (jcsackett)]

So, this isn't necessary to fix, but while you can set official_answers to False to make it not use launchpad, you could also set the answers_usage attribute directly with a value from the ServiceUsage enum, which is more in line with how the code elsewhere sets it (or is *supposed* to set it, in any event).

review: Approve