Merge lp:~sinzui/launchpad/add-private-member into lp:launchpad
Status: | Merged |
---|---|
Approved by: | j.c.sackett |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15641 |
Proposed branch: | lp:~sinzui/launchpad/add-private-member |
Merge into: | lp:launchpad |
Diff against target: |
41 lines (+11/-2) 2 files modified
lib/lp/registry/browser/team.py (+2/-2) lib/lp/registry/browser/tests/test_team.py (+9/-0) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/add-private-member |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+115419@code.launchpad.net |
Commit message
+addmember permits private teams.
Description of the change
Private teams can be added to a team using the "Add team member" picker, but
+addmember gives an error.
-------
RULES
Pre-
* This looks like a vocab issue. What vocab do the picker and form use?
Does the view have a secondary validation that rejects private teams.
* The view uses the ITeamMember schema which wrongly uses
proper validation, but the PublicPersonChoice field adds an unwanted
public team check.
* The field should be PersonChoice as is used in ITeamMembership
QA
* https:/
* Add private-
* Verify the team was accepted
LINT
lib/
lib/
TEST
./bin/test -vvc -t TestTeamMemberAdd lp.registry.
IMPLEMENTATION
Replace PublicPersonChoice with PersonChoice so that the vocabulary does
all the validation.
lib/
lib/
Awesome, glad it was as simple as we had supposed. Thanks.