Merge lp:~sinzui/juju-release-tools/rewrite-devel into lp:juju-release-tools

[Curtis Hovey]

Copy the released simple streams stanza to devel to do mixed juju testing.

I offer this script without tests as a means to unblock CI for a few weeks. I have already run this like so
    ../juju-release-tools/copy_stream.py -v ./index2.json released devel
then republished streams. All the substrate tests are passing.

I intend to update the two jobs that publish testing and weekly streams to run this between assemble-streams and publish-public-tools.

[Aaron Bentley (abentley)]

Looks reasonable. A few nitpicks that needn't block landing:
- It would be nice to use a longer variable name for the opened file, rather than 'f'.
- It would be nice if the main function was compatible with the setup.py console_scripts entry point, i.e. no mandatory parameters.
- Maybe it should error if the to_key is already present? (Or does that break your workflow?)

review: Approve

[lp:~sinzui/juju-release-tools/rewrite-devel]

209. By Curtis Hovey on 2015-08-14

Raise an error when the to_key is already defined.

=== added file 'copy_stream.py'
--- copy_stream.py	1970-01-01 00:00:00 +0000
+++ copy_stream.py	2015-08-14 14:16:38 +0000
@@ -0,0 +1,69 @@
+#!/usr/bin/python
+
+from __future__ import print_function
+
+from argparse import ArgumentParser
+import json
+import os
+import sys
+import traceback
+
+
+STREAM_KEY_TEMPLATE = 'com.ubuntu.juju:{}:tools'
+
+
+def copy(location, from_stream, to_stream, dry_run=False, verbose=False):
+    with open(location, 'r') as index_file:
+        index = json.load(index_file)
+    from_key = STREAM_KEY_TEMPLATE.format(from_stream)
+    to_key = STREAM_KEY_TEMPLATE.format(to_stream)
+    if to_key in index['index']:
+        raise ValueError('{} is already defined in {}'.format(
+                         to_key, location))
+    stanza = dict(index['index'][from_key])
+    index['index'][to_key] = stanza
+    if verbose:
+        product_path = stanza['path']
+        print('copied {} with {} to {}'.format(
+              from_stream, product_path, to_stream))
+    if not dry_run:
+        with open(location, 'w') as index_file:
+            json.dump(index, index_file, indent=4)
+
+
+def parse_args(args=None):
+    """Return the argument parser for this program."""
+    parser = ArgumentParser("Copy simple stream stanzas.")
+    parser.add_argument(
+        '-d', '--dry-run', action="store_true", default=False,
+        help='Do not make changes.')
+    parser.add_argument(
+        '-v', '--verbose', action="store_true", default=False,
+        help='Increase verbosity.')
+    parser.add_argument(
+        'location', type=os.path.expanduser,
+        help='The path to the index2.json')
+    parser.add_argument('from_stream', help='The agent-stream to copy.')
+    parser.add_argument('to_stream', help='The agent-stream to create.')
+    return parser.parse_args(args)
+
+
+def main(argv=None):
+    """Copy simple stream stanzas."""
+    args = parse_args(argv)
+    try:
+        copy(
+            args.location, args.from_stream, args.to_stream,
+            dry_run=args.dry_run, verbose=args.verbose)
+    except Exception as e:
+        print(e)
+        if args.verbose:
+            traceback.print_tb(sys.exc_info()[2])
+        return 2
+    if args.verbose:
+        print("Done.")
+    return 0
+
+
+if __name__ == '__main__':
+    sys.exit(main(sys.argv[1:]))