Merge lp:~sinzui/juju-ci-tools/yaketty-deps into lp:juju-ci-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 1487
Proposed branch: lp:~sinzui/juju-ci-tools/yaketty-deps
Merge into: lp:juju-ci-tools
Diff against target: 34 lines (+4/-2)
2 files modified
Makefile (+0/-2)
juju-ci-tools-common (+4/-0)
To merge this branch: bzr merge lp:~sinzui/juju-ci-tools/yaketty-deps
Reviewer Review Type Date Requested Status
Christopher Lee (community) Approve
Review via email: mp+298437@code.launchpad.net

Description of the change

Update apt dep rules for juju-ci-tools

Some packages are now recommends because note every OS has the package
1. Yakkety does not have juju-quickstart. We only test juju-quickstart on the trusty host.
2. juju-local may disappear soon because the juju2 package does not use it.
3. juju-deployer may disappear when juju improves...it won a reprieve in xenial.

Python-pip is already listed in the expects file. We don't need to install it twice

To post a comment you must log in.
Revision history for this message
Christopher Lee (veebers) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2016-06-20 20:41:12 +0000
3+++ Makefile 2016-06-27 15:31:10 +0000
4@@ -16,8 +16,6 @@
5 install-deps: juju-ci-tools.common_0.1.1-0_all.deb apt-update
6 sudo dpkg -i juju-ci-tools.common_0.1.1-0_all.deb || true
7 sudo apt-get install -y -f
8- sudo apt-get install -y juju-local juju juju-quickstart juju-deployer
9- sudo apt-get install -y python-pip
10 ./pipdeps.py install
11 name=NAMEHERE
12 assess_file=assess_$(name).py
13
14=== modified file 'juju-ci-tools-common'
15--- juju-ci-tools-common 2016-06-22 15:05:53 +0000
16+++ juju-ci-tools-common 2016-06-27 15:31:10 +0000
17@@ -7,6 +7,7 @@
18 Depends: charm,
19 distro-info-data,
20 euca2ools,
21+ juju,
22 python-boto,
23 python-coverage,
24 python-fixtures,
25@@ -22,6 +23,9 @@
26 simplestreams,
27 uvtool,
28 uvtool-libvirt
29+Recommends: juju-quickstart,
30+ juju-deployer,
31+ juju-local
32 Architecture: all
33 Description: juju-ci-tools-common
34 A metapackage providing the dependencies for juju-reports

Subscribers

People subscribed via source and target branches