Merge lp:~sinzui/juju-ci-tools/un-redefine into lp:juju-ci-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 1974
Proposed branch: lp:~sinzui/juju-ci-tools/un-redefine
Merge into: lp:juju-ci-tools
Diff against target: 23 lines (+0/-13)
1 file modified
jujupy/tests/test_version_client.py (+0/-13)
To merge this branch: bzr merge lp:~sinzui/juju-ci-tools/un-redefine
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+321871@code.launchpad.net

Description of the change

Fixed test names to avoid redefinition.

I copied the test names from client to version_client, but did not renamed them.

To post a comment you must log in.
lp:~sinzui/juju-ci-tools/un-redefine updated
1975. By Curtis Hovey

Deleted duplicate test and restored name of other.

Revision history for this message
Aaron Bentley (abentley) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jujupy/tests/test_version_client.py'
2--- jujupy/tests/test_version_client.py 2017-04-03 16:25:51 +0000
3+++ jujupy/tests/test_version_client.py 2017-04-04 15:13:00 +0000
4@@ -361,19 +361,6 @@
5 with self.assertRaises(NameNotAccepted):
6 client.add_cloud_interactive('invalid/name', cloud)
7
8- def test_add_cloud_interactive_vsphere(self):
9- client = self.fake_juju_client()
10- clouds = {'foo': {
11- 'type': 'vsphere',
12- 'endpoint': 'http://bar.example.com',
13- 'regions': {
14- 'harvey': {},
15- 'steve': {},
16- }
17- }}
18- client.add_cloud_interactive('foo', clouds['foo'])
19- self.assertEqual(client._backend.clouds, clouds)
20-
21 def test_add_cloud_interactive_vsphere_invalid_endpoint(self):
22 client = self.fake_juju_client()
23 clouds = {'foo': {

Subscribers

People subscribed via source and target branches