Merge lp:~sinzui/bzr-gtk/precise-commit-0 into lp:bzr-gtk
Status: | Merged |
---|---|
Merged at revision: | 770 |
Proposed branch: | lp:~sinzui/bzr-gtk/precise-commit-0 |
Merge into: | lp:bzr-gtk |
Diff against target: |
71 lines (+41/-0) 2 files modified
commit.py (+1/-0) tests/test_commit.py (+40/-0) |
To merge this branch: | bzr merge lp:~sinzui/bzr-gtk/precise-commit-0 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | Approve | ||
Review via email: mp+89586@code.launchpad.net |
Commit message
Define _last_selected_file in init so that async signal callbacks can use it.
Description of the change
I occasionally see the following traceback when committing use bzr-gtk
r769 on precise:
File "/home/
self.
File "/home/
self.
File "/home/
if self._last_
AttributeError: 'CommitDialog' object has no attribute '_last_
The commit is successful. Looking at the order of events,
_construct_
the cursor-changed signal. _on_treeview_
_last_selected_
_fill_in_
_construct_
The cursor-changed signal may have been called after _fill_in_
but it is often called before with Gtk3.
-------
RULES
* Ensure that CommitDialog.
any signal callback is connected.
QA
While I do know the steps that I see the error, I do not always see it. Maybe
the issue only happens when there is a large tree of changes?
* Run gcommit under precice
* Type a few characters
* Cancel the action
* Save the message
* Verify there is no AttributeError on strout
Thanks for adding tests, bzr-gtk has far too few. :-)