lp:~sinha/drizzle/patch-621856

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~drizzle-trunk/drizzle/development

Lee Bieber (community): Needs Fixing on 2011-03-18

Andrew Hutchings: Approve on 2011-03-17

Stewart Smith: Pending requested 2011-03-15

Diff: 231 lines (+21/-22)

12 files modified

drizzled/join.cc (+1/-2)
drizzled/join_cache.cc (+1/-1)
drizzled/sql_lex.h (+1/-1)
drizzled/sql_parse.cc (+3/-3)
drizzled/sql_parse.h (+2/-2)
drizzled/sql_select.cc (+4/-4)
drizzled/sql_select.h (+4/-4)
drizzled/statement/insert.cc (+1/-1)
drizzled/statement/insert_select.cc (+1/-1)
drizzled/statement/replace.cc (+1/-1)
drizzled/statement/replace_select.cc (+1/-1)
drizzled/statement/update.cc (+1/-1)

api

Superseded for merging into lp:drizzle/7.0

Stewart Smith: Pending requested 2011-03-14

Diff: 231 lines (+21/-22)

12 files modified

drizzled/join.cc (+1/-2)
drizzled/join_cache.cc (+1/-1)
drizzled/sql_lex.h (+1/-1)
drizzled/sql_parse.cc (+3/-3)
drizzled/sql_parse.h (+2/-2)
drizzled/sql_select.cc (+4/-4)
drizzled/sql_select.h (+4/-4)
drizzled/statement/insert.cc (+1/-1)
drizzled/statement/insert_select.cc (+1/-1)
drizzled/statement/replace.cc (+1/-1)
drizzled/statement/replace_select.cc (+1/-1)
drizzled/statement/update.cc (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #621856: Refactor all methods/functions which have unused param

Low

Triaged

Link a bug report

Related blueprints

2237. By Akash Sinha<email address hidden> on 2011-03-17

calc_used_field_length call updated.

2236. By Akash Sinha<email address hidden> on 2011-03-14

sql_select.cc
        #1 int join_no_more_records(ReadRecord *) at line 3549
           sql_select.h file: function altered
           No other calls found

        #2 void calc_used_field_length(Session *, JoinTable *join_tab) at line 847
        sql_select.h file: function altered
        Calls from join.cc and join_cache.cc altered

        #3 enum_nested_loop_state end_send_group(Join *join, JoinTable *, bool end_of_records)
        sql_select.h file: function altered
        no other calls

        #4 enum_nested_loop_state end_write_group(Join *join, JoinTable *, bool end_of_records)
        sql_select.h file: function altered
        no other calls

sql_parse.cc
        #1 TableList *Select_Lex::end_nested_join(Session *) at line 1130
        sql_lex.h file : definition altered
        No other calls found

        #2 bool update_precheck(Session *session, TableList *) at line 1539
        sql_parse.h file: function altered
        statement/update.cc call altered

        #3 bool insert_precheck(Session *session, TableList *) at line 1578
        sql_parse.h file: function altered
        Calls from these files updated
                statement/replace_select.cc
                statement/insert_select.cc
                statement/replace.cc
                statement/insert.cc

2235. By Brian Aker on 2011-03-14

Merge in pcrews.

2234. By Brian Aker on 2011-03-14

Mass removal of ifdef/endif in favor of pragma once.

2233. By Lee Bieber on 2011-03-13

Merge Olaf - Refactor Session

2232. By Lee Bieber on 2011-03-12

Merge Patrick - add suite to test drizzledump
Merge Patrick - 732061: need a way to execute dtr test cases with the slave plugin

2231. By Monty Taylor on 2011-03-11

Merged Brian: New 5.5 auth support.
Merged Dave: Slave admin docs.

2230. By Monty Taylor on 2011-03-11

Merged Andrew: drizzledump and docs bug fixes
Merged Barry: pbms bugfixes

2229. By Monty Taylor on 2011-03-10

Merge Joe and Dave: Replication bug fixes.

2228. By Monty Taylor on 2011-03-10

Merge Olaf: Refactoring Work
Merge Brian: Replication bug fixes
Merge Marisa and Mark: Documentation fixes