Granite

Merge lp:~sindriava+launchpad/granite/fix-958203 into lp:~elementary-pantheon/granite/granite

  1. fix-958203
  2. Merge into granite
Proposed by Cody Garver
Status: Merged
Approved by: Cody Garver
Approved revision: 226
Merged at revision: 225
Proposed branch: lp:~sindriava+launchpad/granite/fix-958203
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 11 lines (+1/-0)
1 file modified
lib/Widgets/PopOver.vala (+1/-0)
To merge this branch: bzr merge lp:~sindriava+launchpad/granite/fix-958203
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+102010@code.launchpad.net

This proposal supersedes a proposal from 2012-04-14.

Description of the change

Manually sets the WM_WINDOW_ROLE to "popover".
Ideally tested with:
  "sleep 5 && xprop WM_WINDOW_ROLE"
The sleep part is because clicking outside of popover closes it.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote : Posted in a previous version of this proposal

Resubmit so that the whitespace change takes effect.

review: Needs Fixing
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/PopOver.vala'
2--- lib/Widgets/PopOver.vala 2012-03-26 20:38:30 +0000
3+++ lib/Widgets/PopOver.vala 2012-04-14 10:19:21 +0000
4@@ -139,6 +139,7 @@
5 public PopOver()
6 {
7 modal = true;
8+ set_role ("popover");
9
10 hbox = get_content_area() as Gtk.Box;
11 abox = get_action_area() as Gtk.Box;

Subscribers

People subscribed via source and target branches