Merge ~simpoir/ubuntu/+source/coreboot:merge/2137738 into ubuntu/+source/coreboot:debian/sid

Proposed by Simon Poirier
Status: Needs review
Proposed branch: ~simpoir/ubuntu/+source/coreboot:merge/2137738
Merge into: ubuntu/+source/coreboot:debian/sid
Diff against target: 62 lines (+25/-1)
3 files modified
debian/changelog (+14/-0)
debian/control (+2/-1)
debian/rules (+9/-0)
Reviewer Review Type Date Requested Status
Skia (community) Approve
git-ubuntu import Pending
Review via email: mp+498322@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Simon Poirier (simpoir) wrote :

Successfully built in PPA, https://launchpad.net/~simpoir/+archive/ubuntu/coreboot/+packages

I attempted a test rebuild without the delta but it is still required for to build ppc64el.

Revision history for this message
Skia (skia) wrote :

Thanks for checking whether we could drop the delta. Unfortunate we can't.

Sponsored:
$ dput ubuntu ../coreboot_25.09+dfsg-1ubuntu1_source.changes
Uploading coreboot using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running checksum: verify checksums before uploading
running releasemismatch: Warn about mismatching suffixesg e.g. focal with a XX.YY not being 20.04
running badauthor: Stop if uploading with root@ or ubuntu@ email adresses.
running ppaforppaonly: Stop uploads to the archive with or to ppa without ~ppa suffix.
running updatemaintainer: Stop if ubuntu changes are without ubuntu maintainer.
running check-debs: makes sure the upload contains a binary package
running gpg: check GnuPG signatures before the upload
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries.
running required-fields: check whether a field is present and non-empty in the changes file
running suite-mismatch: check the target distribution for common errors
running nobug: Stop if uploading without any bug reference.
running placeholderbug: Stop if using common placeholder numbers as bug reference.
Uploading coreboot_25.09+dfsg-1ubuntu1.dsc
Uploading coreboot_25.09+dfsg.orig.tar.xz
Uploading coreboot_25.09+dfsg-1ubuntu1.debian.tar.xz
Uploading coreboot_25.09+dfsg-1ubuntu1_source.buildinfo
Uploading coreboot_25.09+dfsg-1ubuntu1_source.changes

review: Approve

Unmerged commits

c60a591... by Simon Poirier

changelog

bf3d35d... by Simon Poirier

update-maintainer

7a15cb3... by Simon Poirier

reconstruct-changelog

a08f95c... by Simon Poirier

merge-changelogs

961c7a5... by Simon Poirier

  * Don't use -O3 on Ubuntu's amd64 & ppc64el (LP #2099764)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index ef5b2dd..008b28a 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+coreboot (25.09+dfsg-1ubuntu1) resolute; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #2137738). Remaining changes:
9+ - Don't use -O3 on Ubuntu's amd64 & ppc64el (LP #2099764)
10+ * Fixes FTBFS (LP: #2137737)
11+
12+ -- Simon Poirier <simon.poirier@canonical.com> Thu, 08 Jan 2026 18:14:26 -0500
13+
14 coreboot (25.09+dfsg-1) unstable; urgency=medium
15
16 * Fix gcc-15 warning unterminated-string-initialization
17@@ -11,6 +19,12 @@ coreboot (25.09+dfsg-1) unstable; urgency=medium
18
19 -- Ahmad Khalifa <ahmad@khalifa.ws> Sat, 11 Oct 2025 15:25:19 +0100
20
21+coreboot (24.12+dfsg-2ubuntu1) plucky; urgency=medium
22+
23+ * Don't use -O3 on Ubuntu's amd64 & ppc64el (LP: #2099764)
24+
25+ -- Jeremy BĂ­cha <jbicha@ubuntu.com> Thu, 03 Apr 2025 21:41:36 -0400
26+
27 coreboot (24.12+dfsg-2) unstable; urgency=medium
28
29 * d/rules: Quiter build logs, remove DH_VERBOSE
30diff --git a/debian/control b/debian/control
31index 612eb39..10ce9bc 100644
32--- a/debian/control
33+++ b/debian/control
34@@ -1,7 +1,8 @@
35 Source: coreboot
36 Section: utils
37 Priority: optional
38-Maintainer: Ahmad Khalifa <ahmad@khalifa.ws>
39+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
40+XSBC-Original-Maintainer: Ahmad Khalifa <ahmad@khalifa.ws>
41 Build-Depends: debhelper-compat (= 13),
42 libpci-dev,
43 libjs-underscore <!nodoc>,
44diff --git a/debian/rules b/debian/rules
45index cee07ea..dc41738 100755
46--- a/debian/rules
47+++ b/debian/rules
48@@ -10,6 +10,15 @@ ifneq (,$(findstring $(DEB_HOST_ARCH), amd64 i386 x32))
49 COREBOOT_UTILS += bucts ectool intelmetool inteltool msrtool pmh7tool superiotool
50 endif
51
52+# Ubuntu 25.04 uses -O3 by default for amd64 & ppc64el
53+# but the build is failing with -O3 LP: #2099764
54+ifeq ($(shell dpkg-vendor --derives-from Ubuntu && echo yes),yes)
55+ifneq (,$(filter $(DEB_HOST_ARCH),amd64 ppc64el))
56+export DEB_CFLAGS_MAINT_APPEND += -O2
57+export DEB_CFLAGS_MAINT_STRIP += -O3
58+endif
59+endif
60+
61 %:
62 dh $@ --with sphinxdoc
63

Subscribers

People subscribed via source and target branches