Merge lp:~simpoir/landscape-bundles/bumpitty-bump into lp:landscape-bundles

Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 55
Merged at revision: 55
Proposed branch: lp:~simpoir/landscape-bundles/bumpitty-bump
Merge into: lp:landscape-bundles
Diff against target: 51 lines (+5/-5)
2 files modified
landscape-template.jinja2 (+3/-3)
update-charm-revisions (+2/-2)
To merge this branch: bzr merge lp:~simpoir/landscape-bundles/bumpitty-bump
Reviewer Review Type Date Requested Status
Maximiliano Bertacchini Approve
Review via email: mp+406125@code.launchpad.net

Commit message

Fix update-charm-revisions regexp to match current charm Id scheme and bump charms revision.

Description of the change

update-charm-revisions regexp to match current charm Id scheme.

Also bump charms.
This should include this rabbitmq-server HA race condition fix
(https://opendev.org/openstack/charm-rabbitmq-server/commit/dcb3058ff2b730f573329c32a85381a05bd743d3)

thus removing the HA oddities of this related MP
https://code.launchpad.net/~simpoir/landscape-charm/1501803_ha_amqp/+merge/406052

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'landscape-template.jinja2'
2--- landscape-template.jinja2 2019-04-05 10:20:26 +0000
3+++ landscape-template.jinja2 2021-07-22 23:23:12 +0000
4@@ -1,7 +1,7 @@
5 series: bionic
6 services:
7 rabbitmq-server:
8- charm: cs:rabbitmq-server-85
9+ charm: cs:rabbitmq-server-111
10 {% if rabbitmq["to"] %}
11 to:
12 - {{ rabbitmq["to"] }}
13@@ -11,7 +11,7 @@
14 "gui-x": "600"
15 "gui-y": "370"
16 postgresql:
17- charm: cs:postgresql-199
18+ charm: cs:postgresql-234
19 {% if postgresql["memory"] %}
20 constraints: mem={{ postgresql["memory"] }}
21 {% endif %}
22@@ -46,7 +46,7 @@
23 "gui-x": "600"
24 "gui-y": "120"
25 haproxy:
26- charm: cs:haproxy-48
27+ charm: cs:haproxy-61
28 {% if haproxy["to"] %}
29 to:
30 - "{{ haproxy["to"] }}"
31
32=== modified file 'update-charm-revisions'
33--- update-charm-revisions 2019-04-05 12:51:18 +0000
34+++ update-charm-revisions 2021-07-22 23:23:12 +0000
35@@ -51,7 +51,7 @@
36 be tested and checked in if successful.
37
38 Look for lines like:
39- charm: cs:trusty/juju-gui-83
40+ charm: cs:juju-gui-83
41
42 Or:
43 series: trusty
44@@ -60,7 +60,7 @@
45 pattern = "^(\s*)series:\s.*$"
46 line = re.sub(pattern, r"\1series: %s" % series, line)
47 for charm in charms:
48- pattern = "cs:[^/]+/{}-[0-9]+".format(charm.name)
49+ pattern = "cs:{}-[0-9]+".format(charm.name)
50 line = re.sub(pattern, charm.store_url, line)
51 sys.stdout.write(line)
52

Subscribers

People subscribed via source and target branches

to all changes: