Merge lp:~simone.busoli/nunitv2/1043641 into lp:nunitv2

Proposed by Simone Busoli
Status: Merged
Approved by: Charlie Poole
Approved revision: 3431
Merged at revision: 3435
Proposed branch: lp:~simone.busoli/nunitv2/1043641
Merge into: lp:nunitv2
Diff against target: 50 lines (+6/-13)
1 file modified
src/GuiComponents/UiKit/ResultTabs.cs (+6/-13)
To merge this branch: bzr merge lp:~simone.busoli/nunitv2/1043641
Reviewer Review Type Date Requested Status
Charlie Poole Approve
Review via email: mp+129600@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Charlie Poole (charlie.poole) wrote :

It works!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/GuiComponents/UiKit/ResultTabs.cs'
2--- src/GuiComponents/UiKit/ResultTabs.cs 2012-01-11 17:52:54 +0000
3+++ src/GuiComponents/UiKit/ResultTabs.cs 2012-10-14 21:53:19 +0000
4@@ -230,8 +230,6 @@
5 ITestEvents events = Services.TestLoader.Events;
6 errorDisplay.Subscribe( events );
7 notRunTree.Subscribe( events );
8-
9- displayController.Subscribe( events );
10 }
11
12 base.OnLoad (e);
13@@ -350,7 +348,7 @@
14 tabControl.ItemSize = new Size(tabControl.ItemSize.Width, this.Font.Height + 7);
15 }
16
17- private class TextDisplayController : TestObserver
18+ private class TextDisplayController
19 {
20 private TabControl tabControl;
21 List<TextDisplayTabPage> tabPages = new List<TextDisplayTabPage>();
22@@ -416,8 +414,11 @@
23 break;
24 }
25
26- if ( thePage == null )
27- thePage = new TextDisplayTabPage( tabInfo );
28+ if ( thePage == null )
29+ {
30+ thePage = new TextDisplayTabPage( tabInfo );
31+ thePage.Display.Subscribe(Services.TestLoader.Events);
32+ }
33
34 thePage.DisplayFont = displayFont;
35
36@@ -472,14 +473,6 @@
37 ? new Font(FontFamily.GenericMonospace, 8.0f)
38 : settings.GetSetting("Gui.FixedFont", new Font(FontFamily.GenericMonospace, 8.0f));
39 }
40-
41- #region TestObserver Members
42- public void Subscribe(ITestEvents events)
43- {
44- foreach( TextDisplayTabPage page in tabPages )
45- page.Display.Subscribe(events);
46- }
47- #endregion
48 }
49 }
50 }

Subscribers

People subscribed via source and target branches

to status/vote changes: