Code review comment for lp:~simdgenius/inkscape/inkscape

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Hi Yale.
Also you need to handle 32bit platforms and re-read the Tav message to the list about more comments in your code, he is a too much mode advanced dev than me.

Also "some portions not render sometimes but not your problem Is usual in trunk" is only my opinion maybe Im not right and could be part of your code, please be sure. My intention with the comment is reflect is not the only time withe spaces in render happends, but your comment at high level disapear give me to a recheck it well.

Certainy Im not the best man for review your code and if I approve i tell in the darkness, what is not good. In my opinion you need to reply Tav message and try approve with him.

Cheers and thanks for your hard work, Jabier.

« Back to merge proposal