Merge ~silverdrake11/landscape-bundles:scalable_stable_update_postgres into landscape-bundles:scalable-stable

Proposed by Kevin Nasto
Status: Merged
Merged at revision: 5f5c72f6d7f5171e6be6ba52d1d775bde054b58a
Proposed branch: ~silverdrake11/landscape-bundles:scalable_stable_update_postgres
Merge into: landscape-bundles:scalable-stable
Diff against target: 39 lines (+7/-9)
1 file modified
bundle.yaml (+7/-9)
Reviewer Review Type Date Requested Status
Spencer Runde Approve
Review via email: mp+465616@code.launchpad.net

Commit message

Updated stable bundle to latest revision most notable postgres

Description of the change

Manual testing instructions:

juju add-model testbundle
charmcraft pack
juju deploy ./landscape-scalable.zip

juju status
Then go to the haproxy ip address and make sure landscape is working properly

To post a comment you must log in.
Revision history for this message
Spencer Runde (spencerrunde) wrote :

Why are we dropping the `options` section? I can see that the config values default to 100 and 0 in the postgres unit for max_connections and max_prepared_transactions, at least.

If you'd like to verify:

juju ssh postgresql/0
sudo vim /var/snap/charmed-postgresql/common/var/lib/postgresql/postgresql.conf

review: Needs Information
Revision history for this message
Kevin Nasto (silverdrake11) wrote :

The new postgres charm doesn't support those options

Revision history for this message
Spencer Runde (spencerrunde) wrote :

Ah ok. Looks like the postgres charm is doing HA management with patroni... Can't say I'm terribly familiar with it, but my main concern was that setting max_prepared_transactions to 0 would disable them, which would disable two-phase commit and therefore HA/multiple databases. Patroni seems to be dedicated to simplifying HA, so I trust that this config is taken care of as the units scale.

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bundle.yaml b/bundle.yaml
2index 6742acc..4ca2a29 100644
3--- a/bundle.yaml
4+++ b/bundle.yaml
5@@ -5,7 +5,7 @@ docs: https://discourse.charmhub.io/t/landscape-charm-bundles/10638
6 applications:
7 haproxy:
8 charm: ch:haproxy
9- channel: stable
10+ channel: latest/stable
11 revision: 75
12 num_units: 1
13 expose: true
14@@ -16,19 +16,17 @@ applications:
15 ssl_cert: SELFSIGNED
16 landscape-server:
17 charm: ch:landscape-server
18- channel: stable
19- revision: 107
20+ channel: latest/stable
21+ revision: 111
22 num_units: 1
23 constraints: mem=4096
24+ options:
25+ landscape_ppa: ppa:landscape/self-hosted-24.04
26 postgresql:
27 charm: ch:postgresql
28- channel: latest/stable
29- revision: 345
30+ channel: 14/stable
31+ revision: 363
32 num_units: 1
33- options:
34- extra_packages: python*-apt postgresql-contrib postgresql-.*-debversion postgresql-plpython.*
35- max_connections: 500
36- max_prepared_transactions: 500
37 constraints: mem=2048
38 rabbitmq-server:
39 charm: ch:rabbitmq-server

Subscribers

People subscribed via source and target branches

to all changes: