Merge lp:~sillydeveloper/osdf/wp-nav-buttons into lp:osdf/wp

Proposed by Andrew Ettinger
Status: Merged
Merged at revision: 6
Proposed branch: lp:~sillydeveloper/osdf/wp-nav-buttons
Merge into: lp:osdf/wp
Diff against target: 96 lines (+37/-15)
4 files modified
footer.php (+1/-5)
functions.php (+12/-0)
header.php (+12/-10)
style.css (+12/-0)
To merge this branch: bzr merge lp:~sillydeveloper/osdf/wp-nav-buttons
Reviewer Review Type Date Requested Status
Toast McFarland Approve
Review via email: mp+43156@code.launchpad.net

Description of the change

This is not a complete menu system, but an initial pass. Still needs CSS work. But sets up the header / footer part of the menu system integration with our theme.

To post a comment you must log in.
Revision history for this message
Toast McFarland (daimoneze) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'footer.php'
2--- footer.php 2010-12-06 23:27:50 +0000
3+++ footer.php 2010-12-09 02:00:08 +0000
4@@ -6,11 +6,7 @@
5 Open Source Democracy Foundation © 2010
6 </div>
7 <div class="right_footer">
8- <a href="/index.php">Home</a> |
9- <a href="/about.php">About</a> |
10- <a href="/action.php">Action</a> |
11- <a href="/volunteer.php">Help</a> |
12- <a href="/contact.php">Contact</a>
13+ <?php wp_nav_menu( array( 'menu' => 'footer' ) ); ?>
14 </div>
15 </div>
16 </div>
17
18=== modified file 'functions.php'
19--- functions.php 2010-11-25 02:58:47 +0000
20+++ functions.php 2010-12-09 02:00:08 +0000
21@@ -8,6 +8,18 @@
22 if ( is_readable($locale_file) )
23 require_once($locale_file);
24
25+// support menus:
26+add_action( 'init', 'register_my_menus' );
27+
28+function register_my_menus() {
29+ register_nav_menus(
30+ array(
31+ 'header' => __( 'header' ),
32+ 'footer' => __( 'footer' )
33+ )
34+ );
35+}
36+
37 // Get the page number
38 function get_page_number() {
39 if ( get_query_var('paged') ) {
40
41=== modified file 'header.php'
42--- header.php 2010-12-06 23:27:50 +0000
43+++ header.php 2010-12-09 02:00:08 +0000
44@@ -35,17 +35,19 @@
45 </div>
46 </div>
47 <div id="menu_tab">
48- <ul class="menu">
49- <li><a href="/index.php" id='home_link' class="nav">Home</a></li>
50- <li><a href="/wp" id='home_link' class="nav_selected">News</a></li>
51- <li><a href="/about.php" id='about_link' class="nav">About</a></li>
52- <!--li><a target="new" id='updates_link' href="http://www.r-pac.org/blog" class="nav">Updates</a></li-->
53+ <?php wp_nav_menu( array( 'menu' => 'header' ) ); ?>
54+
55+ <? /*
56+ <li><a href="/wp" id='home_link' class="nav_selected">News</a></li>
57+ <li><a href="/about.php" id='about_link' class="nav">About</a></li>
58+ <!--li><a target="new" id='updates_link' href="http://www.r-pac.org/blog" class="nav">Updates</a></li-->
59
60- <li><a href="/action.php" id='action_link' class="nav">Action</a></li>
61- <!--li><a href="/policy.php" id='policy_link' class="nav">Policy</a></li-->
62- <li><a href="/volunteer.php" id='help_link' class="nav">Volunteer</a></li>
63- <li><a href="/contact.php" id='contact_link' class="nav">Contact</a></li>
64- </ul>
65+ <li><a href="/action.php" id='action_link' class="nav">Action</a></li>
66+ <!--li><a href="/policy.php" id='policy_link' class="nav">Policy</a></li-->
67+ <li><a href="/volunteer.php" id='help_link' class="nav">Volunteer</a></li>
68+ <li><a href="/contact.php" id='contact_link' class="nav">Contact</a></li>
69+ */
70+?>
71 </div>
72 </div>
73 <div id="main_content">
74
75=== modified file 'style.css'
76--- style.css 2010-12-06 07:13:04 +0000
77+++ style.css 2010-12-09 02:00:08 +0000
78@@ -9,6 +9,18 @@
79 */
80 @import "http://theosdf.org/style.css";
81
82+#menu_tab ul.menu li a, #menu_tab ul.menu li a:visited {
83+display:block; float:left; padding:0px; margin:0;width:71px; height:37px; margin:0px 4px 0px 4px; text-align:center; color:#FFFFFF;
84+text-decoration:none;}
85+
86+#menu_tab ul.menu li a:link, #menu_tab ul.menu li a:visited {
87+display:block; float:left; padding:0px; margin:0;width: 71px;margin:0px 4px 0px 4px;text-align:center; height:37px;
88+text-decoration:none; color: #d34124; background:url(http://theosdf.org/images/bt_bg.gif) no-repeat center;}
89+
90+#menu_tab ul.menu li a:hover {
91+color: #d34124; text-decoration:none;background:url(http://theosdf.org/images/bt_bg.gif) no-repeat center;}
92+
93+
94 /* body { url(http://r-pac.org/images/bg.gif) repeat-x; } */
95
96 h1.entry-title { color: black; display: block; width: 100%; font-size: 40px; margin-bottom: 20px;}

Subscribers

People subscribed via source and target branches