Merge lp:~sileht/testscenarios/testscenarios into lp:~testtools-committers/testscenarios/trunk

Proposed by Mehdi Abaakouk on 2014-03-14
Status: Work in progress
Proposed branch: lp:~sileht/testscenarios/testscenarios
Merge into: lp:~testtools-committers/testscenarios/trunk
Diff against target: 10 lines (+2/-0)
1 file modified
lib/testscenarios/scenarios.py (+2/-0)
To merge this branch: bzr merge lp:~sileht/testscenarios/testscenarios
Reviewer Review Type Date Requested Status
Robert Collins 2014-03-14 Needs Information on 2014-04-08
Review via email: mp+211038@code.launchpad.net
To post a comment you must log in.
Zygmunt Krynicki (zyga) wrote :

Apart from pointless whitespace changes, this looks good to me

22. By Mehdi Abaakouk on 2014-03-14

Allow use scenario with nose

This patch informs nose that test generated and orignal test are the same.

Closes bug: #872887

Mehdi Abaakouk (sileht) wrote :

I have cleaned the commit.

Victor Stinner (victor-stinner) wrote :

What is the status of this issue? I still need it for a patch on OpenStack Oslo Incubator:
https://review.openstack.org/#/c/80534/2/tests/unit/test_gettext.py

Zygmunt Krynicki (zyga) wrote :

Any of the people listed here can commit this: https://launchpad.net/~testtools-committers (I cannot)

Chmouel Boudjnah (chmouel) wrote :

I'd love to have that!

Robert Collins (lifeless) wrote :

What does this do precisely? The idea that they are the same test case seems wrong, since they *were* but are *no longer* identical.

review: Needs Information
Robert Collins (lifeless) wrote :

This still needs the question asked answered

Robert Collins (lifeless) wrote :

Also the source for testscenarios is now ongithub, please submit a PR there.

Unmerged revisions

22. By Mehdi Abaakouk on 2014-03-14

Allow use scenario with nose

This patch informs nose that test generated and orignal test are the same.

Closes bug: #872887

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/testscenarios/scenarios.py'
2--- lib/testscenarios/scenarios.py 2012-04-04 10:02:46 +0000
3+++ lib/testscenarios/scenarios.py 2014-03-14 14:18:40 +0000
4@@ -52,6 +52,8 @@
5 newtest.shortDescription = (lambda: newtest_desc)
6 for key, value in parameters.iteritems():
7 setattr(newtest, key, value)
8+ # Tell nose that test and newtest are the same testcase
9+ setattr(test, '_nose_case', newtest)
10 return newtest
11
12

Subscribers

People subscribed via source and target branches