Merge lp:~sil2100/unity/unity_dash_tap_duration into lp:unity

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: no longer in the source branch.
Merged at revision: 3016
Proposed branch: lp:~sil2100/unity/unity_dash_tap_duration
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/unityshell/unityshell.xml.in (+1/-1)
To merge this branch: bzr merge lp:~sil2100/unity/unity_dash_tap_duration
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+142273@code.launchpad.net

Commit message

Change the default dash tap duration back to the old 250ms value

Description of the change

- Problem:

Tapping the Super key a little bit slower than 'really fast' does not open the Dash, which confuses the older users. The default tap duration has been changed in a recent version.

- Fix:

Switch back to the 250ms default tap duration for the Dash. It's the old value users are used to and it doesn't seem to break anything.

- Tests:

This specific thing is not tested, and I don't think it's necessary - and tap-opening the dash and lenses is tested by existing tests.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Bug linked, sounds sweet!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/unityshell.xml.in'
2--- plugins/unityshell/unityshell.xml.in 2012-12-07 17:30:43 +0000
3+++ plugins/unityshell/unityshell.xml.in 2013-01-08 09:49:22 +0000
4@@ -157,7 +157,7 @@
5 <_long>Duration (in millseconds) that will count as a tap for opening the Dash.</_long>
6 <min>1</min>
7 <max>1000</max>
8- <default>130</default>
9+ <default>250</default>
10 </option>
11
12 <option name="launcher_opacity" type="float">