Merge lp:~sil2100/unity/launcher_dnd_flicker_new into lp:unity
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2389 |
Proposed branch: | lp:~sil2100/unity/launcher_dnd_flicker_new |
Merge into: | lp:unity |
Diff against target: |
35 lines (+10/-3) 1 file modified
launcher/Launcher.cpp (+10/-3) |
To merge this branch: | bzr merge lp:~sil2100/unity/launcher_dnd_flicker_new |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Smith (community) | Approve | ||
Sam Spilsbury (community) | Approve | ||
Alex Launi | quality | Pending | |
Review via email: mp+105064@code.launchpad.net |
This proposal supersedes a proposal from 2012-04-08.
Commit message
When dragging a non-application, do not saturate all icons automatically, but only those that are needed.
Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230).
Description of the change
Problem description:
When drag-and-dropping from the Dash to the Launcher a non-application icon (for instance, a PNG file), the Launcher 'flickers' a bit. This flickering means that the Launcher icons get desaturated for a moment and then loose saturation again (as originally intended), tinted (LP #863230 and more specifically - LP #971086).
The fix:
During drag and drop, instead of saturating all icons automatically when overlay is present, we only do this when we know that we're not dragging a non-application. Otherwise, only saturate the icons that we will actually 'prelight' (i.e. indicate that can handle the given file). This way, there is no flickering and all icons visualize correctly, as intended. There are no longer any tinting problems as well (as noted by JohnLea).
Test coverage:
The following fix can be tested by manual testing of the specified bugs (LP #863230, LP #971086). Problem no longer occurs.
Please add tests to the suite in manual-tests/