Merge lp:~sil2100/unity/launcher_dnd_flicker into lp:unity
Status: | Superseded |
---|---|
Proposed branch: | lp:~sil2100/unity/launcher_dnd_flicker |
Merge into: | lp:unity |
Diff against target: |
38 lines (+12/-5) 1 file modified
plugins/unityshell/src/Launcher.cpp (+12/-5) |
To merge this branch: | bzr merge lp:~sil2100/unity/launcher_dnd_flicker |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Launi (community) | quality | Approve | |
Review via email: mp+101214@code.launchpad.net |
This proposal has been superseded by a proposal from 2012-05-08.
Commit message
When dragging a non-application, do not saturate all icons automatically, but only those that are needed.
Eliminates flickering before 'prelighting' the Launcher icons that can handle the current drag-and-drop (LP #863230).
Description of the change
Problem description:
When drag-and-dropping from the Dash to the Launcher a non-application icon (for instance, a PNG file), the Launcher 'flickers' a bit. This flickering means that the Launcher icons get desaturated for a moment and then loose saturation again (as originally intended), tinted (LP #863230 and more specifically - LP #971086).
The fix:
During drag and drop, instead of saturating all icons automatically when overlay is present, we only do this when we know that we're not dragging a non-application. Otherwise, only saturate the icons that we will actually 'prelight' (i.e. indicate that can handle the given file). This way, there is no flickering and all icons visualize correctly, as intended. There are no longer any tinting problems as well (as noted by JohnLea).
Test coverage:
The following fix can be tested by manual testing of the specified bugs (LP #863230, LP #971086). Problem no longer occurs.
Unmerged revisions
- 2253. By Łukasz Zemczak
-
If dragging a non-application, do not saturate all icons automatically. Only those needed.
This way, the 'flickering' animation is not visible during drag-and-drop from Dash.
Please add tests to the suite in manual-tests/