Merge lp:~sil2100/unity/autopilot_search_app_lens_toggle into lp:unity

[Łukasz Zemczak]

Add a workaround for bug LP: #1152517 in the test_search autopilot suite. We toggle the dash once before starting any app lens tests

- Problem:

unity.tests.test_search.ApplicationLensSearchTests.test_application_lens_search(basic) fails *always* on the jenkins autopilot builders. Only once, on all machines. I suspect it might be because lenses are not loaded correctly and Super+a is not recognized.

- Fix:

Workaround: for the very first time an app lens search test is executed, toggle the dash and unblock Super+a. It's only temporary until the root cause is not found finally, while until that time we need to have the releases unblocked.

- Tests:

N/A

This branch needs testing if it works-around the problem correctly.

[Andrea Azzarone (azzar1)]

Approving it. We'll continue to work to find the real cause of this problem.

review: Approve

[Łukasz Zemczak (sil2100)]

Let's wait with approving this branch until we get the latest indicator results, since there's a probability that the bug 'fixed itself'? Or something.

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/474/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/474/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=i386/474/console

review: Needs Fixing (continuous-integration)

[Francis Ginther (fginther)]

Network issue during test run caused failure. Reapproving.

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/unity/tests/test_search.py'
--- tests/autopilot/unity/tests/test_search.py	2013-03-06 09:23:32 +0000
+++ tests/autopilot/unity/tests/test_search.py	2013-03-08 12:00:30 +0000
@@ -18,6 +18,11 @@
 
 import gettext
 
+# XXX: Ugly workaround for a really annoying bug (LP: #1152517) which breaks
+#  this test suite. So, to workaround, we toggle the dash once before doing any
+#  app lens search tests
+workaround_lenses_load_done = False
+
 class SearchTestsBase(UnityTestCase):
     """Base class for testing searching in search fields.
       
@@ -61,6 +66,13 @@
 
     def setUp(self):
         super(ApplicationLensSearchTestBase, self).setUp()
+        # XXX: Temporary workaround for LP: #1152517
+        global workaround_lenses_load_done
+        if not workaround_lenses_load_done:
+            self.unity.dash.ensure_visible()
+            self.unity.dash.ensure_hidden()
+            workaround_lenses_load_done = True
+
         self.app_lens = self.unity.dash.reveal_application_lens()
         self.addCleanup(self.unity.dash.ensure_hidden)
         gettext.install("unity-lens-applications", unicode=True)