Code review comment for lp:~sil2100/unity/autopilot_ibus_improve

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi,

First, when running the tests, I get:

/tmp/autopilot_ibus_improve/tests/autopilot/unity/tests/test_ibus.py:48: PyGIDeprecationWarning: MainLoop is deprecated; use GLib.MainLoop instead
  self._glibloop = GObject.MainLoop()

(autopilot:15226): IBUS-WARNING **: org.freedesktop.IBus.InputContext.GetEngine: GDBus.Error:org.freedesktop.IBus.Error.NoEngine: Input context does not have engine.
/tmp/autopilot_ibus_improve/tests/autopilot/unity/tests/test_ibus.py:79: PyGIDeprecationWarning: timeout_add_seconds is deprecated; use GLib.timeout_add_seconds instead
  GObject.timeout_add_seconds(10, lambda *args: self._glibloop.quit())

So we should fix that. Seconf, they enter an endless loop where they constantly print:

(autopilot:15226): IBUS-WARNING **: org.freedesktop.IBus.InputContext.GetEngine: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface `org.freedesktop.IBus.InputContext' on object at path /org/freedesktop/IBus/InputContext_58

so I can't actually run the tests to verify that they work as expected.

review: Needs Fixing

« Back to merge proposal