Merge lp:~sil2100/unity/autopilot_disable_screen_lock into lp:unity

[Łukasz Zemczak]

Disable screen locking during autopilot test runs

- Problem:

Sometimes when an autopilot test runs, the screen gets locked and we get failures on jenkins.

- Fix:

Disable screen locking through gsettings on every test start and re-enable it back again in the end.

- Tests:

N/A
(But maybe we should add one ;) ? )

[Michael Terry (mterry)]

Idea seems great, thanks for it.

But we should restore original value rather than always cleaning up with True.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3301
http://jenkins.qa.ubuntu.com/job/unity-ci/19/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-armhf-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-i386-ci/19

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/19/rebuild

review: Approve (continuous-integration)

[Łukasz Zemczak (sil2100)]

Right, where was my head when I was writing this. Fixing!

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3302
http://jenkins.qa.ubuntu.com/job/unity-ci/20/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-amd64-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-armhf-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-raring-i386-ci/20

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/20/rebuild

review: Approve (continuous-integration)

[Didier Roche-Tolomelli (didrocks)]

the gsettings part looks fine, not sure where it should be in the autopilot part though, so we need an autopilot expert for the finale ack.

review: Approve

[Christopher Lee (veebers)]

Cool, looks like a good stopgap measure until we figure out why we sometimes have tests fail really hard :-)

review: Approve

=== modified file 'tests/autopilot/unity/tests/__init__.py'
--- tests/autopilot/unity/tests/__init__.py	2013-04-09 18:37:33 +0000
+++ tests/autopilot/unity/tests/__init__.py	2013-04-15 22:43:30 +0000
@@ -43,6 +43,7 @@
 from Xlib import display
 from Xlib import Xutil
 
+from gi.repository import Gio
 
 log = getLogger(__name__)
 
@@ -66,6 +67,12 @@
         # ropey. Once it's been proven to work reliably we can remove this line:
         self.set_unity_log_level("unity.wm.compiz", "DEBUG")
 
+        # For the length of the test, disable screen locking
+        self._desktop_settings = Gio.Settings.new("org.gnome.desktop.lockdown")
+        lock_state = self._desktop_settings.get_boolean("disable-lock-screen")
+        self._desktop_settings.set_boolean("disable-lock-screen", True)
+        self.addCleanup(self._desktop_settings.set_boolean, "disable-lock-screen", lock_state)
+
     def check_test_behavior(self):
         """Fail the test if it did something naughty.