Merge lp:~sil2100/unity-voice/fix_ftbfs_on_amd64 into lp:unity-voice

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Pete Woods
Approved revision: 34
Merged at revision: 33
Proposed branch: lp:~sil2100/unity-voice/fix_ftbfs_on_amd64
Merge into: lp:unity-voice
Diff against target: 46 lines (+1/-11)
3 files modified
cmake/FindValgrind.cmake (+1/-1)
debian/control (+0/-1)
debian/rules (+0/-9)
To merge this branch: bzr merge lp:~sil2100/unity-voice/fix_ftbfs_on_amd64
Reviewer Review Type Date Requested Status
Pete Woods (community) Approve
Review via email: mp+273414@code.launchpad.net

Commit message

Disable valgrind memcheck during testing as it's causing a test failure on amd64 (due to valgrind being angry at Qt internals). Remove the valgrind build-dependency.

Description of the change

Disable valgrind memcheck during testing as it's causing a test failure on amd64 (due to valgrind being angry at Qt internals). Remove the valgrind build-dependency.

To post a comment you must log in.
34. By Łukasz Zemczak

Change the FindValgrind.cmake bits to have memcheck disabled by default.

Revision history for this message
Pete Woods (pete-woods) wrote :

Awesome

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/FindValgrind.cmake'
2--- cmake/FindValgrind.cmake 2014-01-03 11:56:18 +0000
3+++ cmake/FindValgrind.cmake 2015-10-05 14:39:59 +0000
4@@ -2,7 +2,7 @@
5 option(
6 ENABLE_MEMCHECK_OPTION
7 "If set to ON, enables automatic creation of memcheck targets"
8- ON
9+ OFF
10 )
11
12 find_program(
13
14=== modified file 'debian/control'
15--- debian/control 2014-01-03 11:56:18 +0000
16+++ debian/control 2015-10-05 14:39:59 +0000
17@@ -15,7 +15,6 @@
18 qtbase5-dev,
19 sphinx-voxforge-hmm-en,
20 sphinx-voxforge-lm-en,
21- valgrind [!arm64 !ppc64el],
22 Standards-Version: 3.9.4
23 Homepage: https://launchpad.net/unity-voice
24 # if you don't have have commit access to this branch but would like to upload
25
26=== modified file 'debian/rules'
27--- debian/rules 2014-03-03 13:33:24 +0000
28+++ debian/rules 2015-10-05 14:39:59 +0000
29@@ -3,17 +3,8 @@
30
31 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
32
33-ifeq ($(DEB_HOST_ARCH),armhf)
34- ENABLE_MEMCHECK_OPTION = OFF
35-else
36- ENABLE_MEMCHECK_OPTION = ON
37-endif
38-
39 %:
40 dh $@ --parallel --fail-missing
41
42-override_dh_auto_configure:
43- dh_auto_configure -- -DENABLE_MEMCHECK_OPTION=${ENABLE_MEMCHECK_OPTION}
44-
45 override_dh_makeshlibs:
46 dh_makeshlibs -V

Subscribers

People subscribed via source and target branches

to all changes: