Merge lp:~sil2100/unity-scopes-shell/packaging_review into lp:unity-scopes-shell

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 17
Merged at revision: 17
Proposed branch: lp:~sil2100/unity-scopes-shell/packaging_review
Merge into: lp:unity-scopes-shell
Diff against target: 89 lines (+20/-9)
6 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+5/-1)
debian/control (+9/-3)
debian/copyright (+2/-0)
debian/rules (+1/-4)
debian/source/format (+1/-1)
To merge this branch: bzr merge lp:~sil2100/unity-scopes-shell/packaging_review
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+195815@code.launchpad.net

Commit message

First preliminary packaging review for daily-release enablement

Description of the change

First preliminary packaging review for daily-release enablement

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

the debian/rules changes seems backward, you are going to have the --fail-missing added to other commands than dh_install, is that needed?

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems people disagree on the fail-missing use, let's not block on that...

Revision history for this message
Sebastien Bacher (seb128) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.bzr-builddeb'
2=== added file '.bzr-builddeb/default.conf'
3--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
4+++ .bzr-builddeb/default.conf 2013-11-19 16:10:32 +0000
5@@ -0,0 +1,2 @@
6+[BUILDDEB]
7+split = True
8
9=== modified file 'debian/changelog'
10--- debian/changelog 2013-11-13 12:43:00 +0000
11+++ debian/changelog 2013-11-19 16:10:32 +0000
12@@ -1,5 +1,9 @@
13-unity-scopes-shell (0.1) UNRELEASED; urgency=low
14+unity-scopes-shell (0.1-0ubuntu1) UNRELEASED; urgency=low
15
16+ [ Michal Hruby ]
17 * Initial release
18
19+ [ Łukasz 'sil2100' Zemczak ]
20+ * Automatic snapshot from revision 16 (bootstrap)
21+
22 -- Michal Hruby <michal.hruby@canonical.com> Tue, 12 Nov 2013 15:52:35 +0000
23
24=== modified file 'debian/control'
25--- debian/control 2013-11-18 17:58:14 +0000
26+++ debian/control 2013-11-19 16:10:32 +0000
27@@ -11,10 +11,13 @@
28 qt5-default,
29 qtdeclarative5-dev,
30 qtdeclarative5-dev-tools,
31- qtdeclarative5-qtquick2-plugin
32+ qtdeclarative5-qtquick2-plugin,
33 Standards-Version: 3.9.4
34 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
35 Homepage: https://launchpad.net/unity-scopes-shell
36+# if you don't have have commit access to this branch but would like to upload
37+# directly to Ubuntu, don't worry: your changes will be merged back into the
38+# upstream branch
39 Vcs-Bzr: lp:unity-scopes-shell
40 Vcs-Browser: https://code.launchpad.net/unity-scopes-shell
41
42@@ -22,8 +25,11 @@
43 Architecture: any
44 Multi-Arch: same
45 Pre-Depends: ${misc:Pre-Depends}
46-Depends: qtdeclarative5-dee-plugin, ${misc:Depends}, ${shlibs:Depends}
47-Provides: unity-scopes-impl, unity-scopes-impl-0
48+Depends: ${misc:Depends},
49+ ${shlibs:Depends},
50+ qtdeclarative5-dee-plugin,
51+Provides: unity-scopes-impl,
52+ unity-scopes-impl-0,
53 Breaks: unity8-private (<< 7.84)
54 Replaces: unity8-private (<< 7.84)
55 Description: QML plugin for Scopes
56
57=== modified file 'debian/copyright'
58--- debian/copyright 2013-11-12 17:09:33 +0000
59+++ debian/copyright 2013-11-19 16:10:32 +0000
60@@ -1,4 +1,6 @@
61 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
62+Upstream-Name: unity-scopes-shell
63+Source: http://launchpad.net/unity-scopes-shell
64
65 Files: *
66 Copyright: 2013 Canonical Ltd.
67
68=== modified file 'debian/rules'
69--- debian/rules 2013-11-12 17:09:33 +0000
70+++ debian/rules 2013-11-19 16:10:32 +0000
71@@ -6,10 +6,7 @@
72 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
73
74 %:
75- dh $@ --parallel
76-
77-override_dh_install:
78- dh_install --fail-missing
79+ dh $@ --parallel --fail-missing
80
81 override_dh_auto_configure:
82 dh_auto_configure -- -DLIBDIR=/usr/lib/$(DEB_HOST_MULTIARCH)
83
84=== modified file 'debian/source/format'
85--- debian/source/format 2013-11-12 17:09:33 +0000
86+++ debian/source/format 2013-11-19 16:10:32 +0000
87@@ -1,1 +1,1 @@
88-3.0 (native)
89+1.0

Subscribers

People subscribed via source and target branches

to all changes: