Merge lp:~sil2100/unity-scope-sshsearch/add_dbus_dep into lp:unity-scope-sshsearch

[Łukasz Zemczak]

We're missing the dbus-x11 dependency for the tests, add it now and fix the FTBFS

We have a FTBFS in the PPA since dbus is not being installed, so the tests are failing (missing /var/lib/dbus/machine-id). Probably. Comment?

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:11
http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-i386-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-sshsearch-ci/4/rebuild

review: Needs Fixing (continuous-integration)

[Paweł Stołowski (stolowski)]

It seems to me the root cause is the lack of machine-id file; this file is generated by dbus package (on install and on start of dbus upstart job). python-dbus doesn't pull dbus dependency, so I'm not sure if this solves the problem.

review: Abstain

[Łukasz Zemczak (sil2100)]

I think this would solve the problem as python-dbus implicates installing dbus. The dependency tree is like this: python-dbus depends on libdbus-1-3, libdbus-1-3 recommends dbus (Ubuntu installs by default the recommends). So implicitly dbus should be installed. The thing is, I don't really have the means to check if it really works or not. Or whether we need python-dbus, the whole thing, or just dbus.

[Łukasz Zemczak (sil2100)]

Actually, you're right. Sadly it seems that the builders do not pull-in recommends by default. So let me just add 'dbus'.

review: Needs Fixing

[Paweł Stołowski (stolowski)]

+1

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-autolanding/5/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-amd64-autolanding/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-armhf-autolanding/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-i386-autolanding/2/console

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:12
http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-ci/5/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-armhf-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-i386-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-sshsearch-ci/5/rebuild

review: Needs Fixing (continuous-integration)

[Paweł Stołowski (stolowski)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-autolanding/6/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-amd64-autolanding/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-armhf-autolanding/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-i386-autolanding/3/console

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:13
http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-ci/6/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-amd64-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-sshsearch-raring-i386-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-sshsearch-ci/6/rebuild

review: Needs Fixing (continuous-integration)

[Łukasz Zemczak (sil2100)]

It seems that this is a bigger issue...

review: Disapprove

Unmerged revisions

13. By Łukasz Zemczak on 2013-05-20

Actually, dbus is not enough, we require dbus-launch. So dbus-x11 instead

12. By Łukasz Zemczak on 2013-05-20

Instead of python-dbus, we need to give dbus, as recommends aren't pulled by default in the builders

11. By Łukasz Zemczak on 2013-05-20

We're missing the python-dbus dependency, add it now and fix the FTBFS

=== modified file 'debian/control'
--- debian/control	2013-03-21 20:51:42 +0000
+++ debian/control	2013-05-20 09:56:28 +0000
@@ -11,6 +11,7 @@
                gir1.2-unity-5.0 (>= 6.91),
                gir1.2-glib-2.0,
                python-paramiko,
+               dbus-x11,
 Standards-Version: 3.9.4
 Homepage: https://launchpad.net/unity-scope-sshsearch
 # If you aren't a member of ~submarine but need to upload packaging changes,