Unity GTK+ module

Merge lp:~sil2100/unity-gtk-module/remove_conffile into lp:unity-gtk-module/13.10

  1. remove_conffile
  2. Merge into trunk.13.10
Proposed by Łukasz Zemczak
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 306
Merged at revision: 304
Proposed branch: lp:~sil2100/unity-gtk-module/remove_conffile
Merge into: lp:unity-gtk-module/13.10
Diff against target: 17 lines (+2/-0)
2 files modified
debian/control (+1/-0)
debian/unity-gtk-module-common.maintscript (+1/-0)
To merge this branch: bzr merge lp:~sil2100/unity-gtk-module/remove_conffile
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Didier Roche-Tolomelli Approve
Review via email: mp+174969@code.launchpad.net

Commit message

Make sure to use dpkg-maintscript-helper and dh_builddeb to remove the old obsolete Xsession conffile

Description of the change

Make sure to use dpkg-maintscript-helper to remove the old obsolete Xsession conffile

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

12:45:07 didrocks | sil2100: hum
12:45:11 didrocks | I think you have a better way
12:45:16 didrocks | sil2100: btw, your local test run?
12:45:21 didrocks | removing the file manually
12:45:29 didrocks | and the job comes up after that?
12:45:32 didrocks | (at login)
12:46:58 didrocks | sil2100: man dh_installdeb
12:47:04 didrocks | package.maintscript
12:47:11 didrocks | that will create the maintainer scripts file
12:47:16 didrocks | without you having to deal with symlinks

Can you please convert to that?

review: Needs Fixing
lp:~sil2100/unity-gtk-module/remove_conffile updated
305. By Łukasz Zemczak

Use the dh_installdeb approach

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Needs to fix prior-version as per man page:
didrocks | sil2100: hum, the version isn't right
didrocks | it should be 20130716
didrocks | "prior-version should be based on the version of the package that you
didrocks | are now preparing"
didrocks | from the manpage

review: Needs Fixing
lp:~sil2100/unity-gtk-module/remove_conffile updated
306. By Łukasz Zemczak

Version problem

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

approved!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-06-06 06:25:18 +0000
3+++ debian/control 2013-07-16 11:44:24 +0000
4@@ -7,6 +7,7 @@
5 libx11-dev,
6 libgtk2.0-dev,
7 libgtk-3-dev,
8+Pre-Depends: dpkg (>= 1.15.7.2),
9 Standards-Version: 3.9.4
10 Section: libs
11 Homepage: https://code.launchpad.net/unity-gtk-module
12
13=== added file 'debian/unity-gtk-module-common.maintscript'
14--- debian/unity-gtk-module-common.maintscript 1970-01-01 00:00:00 +0000
15+++ debian/unity-gtk-module-common.maintscript 2013-07-16 11:44:24 +0000
16@@ -0,0 +1,1 @@
17+rm_conffile /etc/X11/Xsession.d/80unity-gtk-module 0.0.0+13.10.20130716.1

Subscribers

People subscribed via source and target branches