Merge lp:~sil2100/unity-2d/revert_and_fix into lp:unity-2d

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 1146
Merged at revision: 1142
Proposed branch: lp:~sil2100/unity-2d/revert_and_fix
Merge into: lp:unity-2d
Diff against target: 137 lines (+11/-50)
6 files modified
debian/changelog (+9/-14)
panel/applets/appname/appnameapplet.cpp (+0/-6)
panel/applets/appname/windowhelper.cpp (+0/-26)
panel/applets/appname/windowhelper.h (+0/-2)
po/CMakeLists.txt (+1/-1)
po/update-unity-2d-pot (+1/-1)
To merge this branch: bzr merge lp:~sil2100/unity-2d/revert_and_fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
unity-2d-team Pending
Review via email: mp+132027@code.launchpad.net

Commit message

Revert 1109 and 1095 due to non-compliance with SRU criteria. Fixed some changelog mistakes.

Description of the change

Reverting two commits as pointed out by Didier. Also, fixed some changelog mistakes made.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~sil2100/unity-2d/revert_and_fix updated
1146. By Łukasz Zemczak

More fixes for the changelog

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-02 11:00:12 +0000
3+++ debian/changelog 2012-10-30 10:21:23 +0000
4@@ -1,31 +1,26 @@
5 unity-2d (5.14.0-0ubuntu1) UNRELEASED; urgency=low
6
7- [ Francis Ginther ]
8- * Update build dependency to the renamed libgeis-dev (LP: #1046392)
9-
10- [ Łukasz 'sil2100' Zemczak ]
11 * New upstream release:
12- - Translation template is not generated during the build (LP: #933468)
13 - Unity 2D doesn't load 24 bit icons (LP: #977262)
14- - [Launcher] [Multi-monitor] Removing a non running app tile from a launcher should remove it from all (LP: #988739)
15- - Panel Titlebar double click is emitted for any mouse button (LP: #73649)
16+ - [Launcher] [Multi-monitor] Removing a non running app tile from a
17+ launcher should remove it from all (LP: #988739)
18+ - Panel Titlebar double click is emitted for any mouse button (LP: #736491)
19 - Launcher does not hide if shown while dragging a file (LP: #1002308)
20 - icon isn't reset when clearing the search query (LP: #973225)
21 - Issue when ejecting busy device from the Unity 2D Shell (LP: #997786)
22 - Sticky edges don't work in RTL (LP: #984092)
23- - pips are not correctly updated when plugin in a second monitor (LP: #1003943)
24+ - pips are not correctly updated when plugin in a second monitor
25+ (LP: #1003943)
26 - [dash] Unable to maximize (LP: #918648)
27- - all panels have same window focus on multiple monitors unity2d (LP: #930147)
28- - clicking on top panel should raise maximized windows (LP: #731761)
29+ - all panels have same window focus on multiple monitors unity2d
30+ (LP: #930147)
31 - Dash will not open files under Greek folders (LP: #1002710)
32 - Launcher does not respond to changes in icon theme (LP: #605475)
33 - [panel] Invisible items in systray (LP: #703389)
34 - [panel] Ignores "enabled" property on top-level menus (LP: #850017)
35- - dropdown boxes on sites stop working (LP: #1010466)
36- - Update dependency on the renamed libgeis (LP: #1046392)
37- - No image for dash icon (LP: #1056108)
38+ * Reverted some quantal-specific commits which are no longer relevant
39
40- -- Francis Ginther <francis.ginther@canonical.com> Tue, 04 Sep 2012 14:39:28 -0500
41+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Tue, 30 Oct 2012 09:59:49 +0100
42
43 unity-2d (5.12.0-0ubuntu1.2) precise-updates; urgency=low
44
45
46=== modified file 'panel/applets/appname/appnameapplet.cpp'
47--- panel/applets/appname/appnameapplet.cpp 2012-05-25 09:12:26 +0000
48+++ panel/applets/appname/appnameapplet.cpp 2012-10-30 10:21:23 +0000
49@@ -400,12 +400,6 @@
50
51 void AppNameApplet::mousePressEvent(QMouseEvent* event) {
52 if (event->button() == Qt::LeftButton) {
53- if (!d->m_label->geometry().contains(event->pos()) || !d->m_label->isVisible()) {
54- // Clicked outside the label and outside the menus
55- // focus the top most maximized window
56- d->m_windowHelper->focusTopMostMaximizedWindowOnScreen();
57- }
58-
59 d->m_dragStartPosition = event->pos();
60 d->m_dragInProgress = true;
61 } else {
62
63=== modified file 'panel/applets/appname/windowhelper.cpp'
64--- panel/applets/appname/windowhelper.cpp 2012-06-13 14:11:37 +0000
65+++ panel/applets/appname/windowhelper.cpp 2012-10-30 10:21:23 +0000
66@@ -178,32 +178,6 @@
67 return true;
68 }
69
70-void WindowHelper::focusTopMostMaximizedWindowOnScreen() const
71-{
72- WnckWindow *topMostMaximizedWindowOnScreen = NULL;
73- GList *stack = wnck_screen_get_windows_stacked(wnck_screen_get_default());
74- GList *cur = stack;
75- while (cur) {
76- WnckWindow *window = (WnckWindow*) cur->data;
77-
78- if (window != NULL) {
79- if (wnck_window_is_maximized(window)) {
80- // Check the window screen
81- int x, y, width, height;
82- wnck_window_get_geometry(window, &x, &y, &width, &height);
83- if (QApplication::desktop()->screenNumber(QRect(x, y, width, height).center()) == d->screen()) {
84- topMostMaximizedWindowOnScreen = window;
85- }
86- }
87- }
88- cur = g_list_next(cur);
89- }
90-
91- if (topMostMaximizedWindowOnScreen) {
92- wnck_window_activate(topMostMaximizedWindowOnScreen, CurrentTime);
93- }
94-}
95-
96 void WindowHelper::close()
97 {
98 if (DashClient::instance()->activeInScreen(d->screen())) {
99
100=== modified file 'panel/applets/appname/windowhelper.h'
101--- panel/applets/appname/windowhelper.h 2012-05-25 09:12:26 +0000
102+++ panel/applets/appname/windowhelper.h 2012-10-30 10:21:23 +0000
103@@ -44,8 +44,6 @@
104 bool isMaximized() const;
105 bool isMostlyOnScreen(int screen) const;
106
107- void focusTopMostMaximizedWindowOnScreen() const;
108-
109 public Q_SLOTS:
110 void close();
111 void minimize();
112
113=== modified file 'po/CMakeLists.txt'
114--- po/CMakeLists.txt 2012-04-13 08:26:38 +0000
115+++ po/CMakeLists.txt 2012-10-30 10:21:23 +0000
116@@ -50,7 +50,7 @@
117
118 create_translation_targets(${GETTEXT_PACKAGE}.pot ${PO_FILES})
119
120-add_custom_target(${GETTEXT_PACKAGE}.pot ALL
121+add_custom_target(${GETTEXT_PACKAGE}.pot
122 COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/update-unity-2d-pot
123 )
124
125
126=== modified file 'po/update-unity-2d-pot'
127--- po/update-unity-2d-pot 2012-04-13 08:26:48 +0000
128+++ po/update-unity-2d-pot 2012-10-30 10:21:23 +0000
129@@ -10,7 +10,7 @@
130 trap 'rm -f "$GETTEXT_FILES"' EXIT
131 cd ..
132 find \( -name '*.cpp' -o -name '*.qml' \) \
133- -a ! \( -path './debian/*' -o -path './build/*' -o -path './obj-*-linux-gnu/*' -o -path './.bzr/*' -o -path './libunity-2d-private/tests/*' \) | sort \
134+ -a ! \( -path './debian/*' -o -path './build/*' -o -path './obj-*-linux-gnu/*' -o -path './.bzr/*' -o -path './libunity-2d-private/tests/*' \) \
135 > $GETTEXT_FILES
136
137 # Generate pot from our list

Subscribers

People subscribed via source and target branches