Merge lp:~sil2100/ubuntu/raring/google-mock/switch_to_dh_python into lp:ubuntu/raring/google-mock

Proposed by Łukasz Zemczak
Status: Merged
Merged at revision: 9
Proposed branch: lp:~sil2100/ubuntu/raring/google-mock/switch_to_dh_python
Merge into: lp:ubuntu/raring/google-mock
Diff against target: 46 lines (+9/-4)
3 files modified
debian/changelog (+7/-0)
debian/control (+1/-1)
debian/rules (+1/-3)
To merge this branch: bzr merge lp:~sil2100/ubuntu/raring/google-mock/switch_to_dh_python
Reviewer Review Type Date Requested Status
Michael Terry Needs Fixing
Didier Roche-Tolomelli Needs Fixing
Ubuntu branches Pending
Review via email: mp+138435@code.launchpad.net

Commit message

* debian/rules, debian/control:
  - Switched from using python-support to dh_python2

Description of the change

* debian/rules, debian/control:
  - Switched from using python-support to dh_python2

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

42 override_dh_pysupport:
43 - dh_pysupport debian/google-mock/usr/share/google-mock/cpp
44 + dh_python2 debian/google-mock/usr/share/google-mock/cpp

I think that removing this stenza and having directly dh --with python2 should do the same, can you try something around that please?

The rest looks good :)

review: Needs Fixing
10. By Łukasz Zemczak

Make it better as suggested by Didier!

Revision history for this message
Michael Terry (mterry) wrote :

This looks good except for the hard-coded python Depends. That will come from ${python:Depends} just fine. With that fix, approved.

review: Needs Fixing
11. By Łukasz Zemczak

Remove the hard-coded python dependency.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Done. Actually, I added this dependency because lintian was spouting warnings about that, since the python dep wasn't added during one of my test builds through ${python:Depends}. But I think this was due to an earlier packaging error I made. So it indeed should be all fine now, sorry about that one ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-11-09 09:56:28 +0000
3+++ debian/changelog 2012-12-07 11:09:22 +0000
4@@ -1,3 +1,10 @@
5+google-mock (1.6.0-0ubuntu3) UNRELEASED; urgency=low
6+
7+ * debian/rules, debian/control:
8+ - Switched from using python-support to dh_python2
9+
10+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Thu, 06 Dec 2012 12:15:20 +0100
11+
12 google-mock (1.6.0-0ubuntu2) raring; urgency=low
13
14 * debian/copyright:
15
16=== modified file 'debian/control'
17--- debian/control 2011-07-01 02:44:57 +0000
18+++ debian/control 2012-12-07 11:09:22 +0000
19@@ -3,7 +3,7 @@
20 Priority: optional
21 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
22 XSBC-Original-Maintainer: Fredrik Hallenberg <hallon@debian.org>
23-Build-Depends: debhelper (>= 7.0.50~), autotools-dev, python-support, libgtest-dev (>= 1.6.0)
24+Build-Depends: debhelper (>= 7.0.50~), autotools-dev, python-dev (>= 2.6.6-3~), libgtest-dev (>= 1.6.0)
25 Standards-Version: 3.9.1
26 Homepage: http://code.google.com/p/googlemock/
27
28
29=== modified file 'debian/rules'
30--- debian/rules 2012-11-09 08:51:38 +0000
31+++ debian/rules 2012-12-07 11:09:22 +0000
32@@ -5,7 +5,7 @@
33 #export DH_VERBOSE=1
34
35 %:
36- dh $@
37+ dh $@ --with python2
38
39 override_dh_auto_configure:
40 dh_auto_configure -- --enable-external-gtest
41@@ -17,5 +17,3 @@
42 rm -f debian/google-mock/usr/lib/libgtest*
43 rm -rf debian/google-mock/usr/include/gtest*
44
45-override_dh_pysupport:
46- dh_pysupport debian/google-mock/usr/share/google-mock/cpp

Subscribers

People subscribed via source and target branches