Merge lp:~sil2100/ubuntu-ui-extras/rename_source_name into lp:~ubuntu-sdk-team/ubuntu-ui-extras/trunk

Proposed by Łukasz Zemczak on 2013-08-21
Status: Merged
Approved by: Łukasz Zemczak on 2013-08-21
Approved revision: 53
Merged at revision: 48
Proposed branch: lp:~sil2100/ubuntu-ui-extras/rename_source_name
Merge into: lp:~ubuntu-sdk-team/ubuntu-ui-extras/trunk
Diff against target: 50 lines (+7/-6)
3 files modified
debian/changelog (+1/-1)
debian/control (+4/-5)
debian/copyright (+2/-0)
To merge this branch: bzr merge lp:~sil2100/ubuntu-ui-extras/rename_source_name
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve on 2013-08-21
PS Jenkins bot continuous-integration Approve on 2013-08-21
Timo Jyrinki (community) 2013-08-21 Needs Fixing on 2013-08-21
Review via email: mp+181213@code.launchpad.net

Commit message

Rename the source package name to ubuntu-ui-extras, change the binary package name to the new standard: qtdeclarative5-ubuntu-ui-extras0.1 (version number attached)

Description of the change

Rename the source package name to ubuntu-ui-extras

Somehow missed this in my review ;/

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Timo Jyrinki (timo-jyrinki) wrote :

Needs fixing also in changelog.

review: Needs Fixing
49. By Łukasz Zemczak on 2013-08-21

Eeek, changelog

50. By Łukasz Zemczak on 2013-08-21

Add additional info to copyright

51. By Łukasz Zemczak on 2013-08-21

As requested by seb, change the name of the binary package to have the version in the name

52. By Łukasz Zemczak on 2013-08-21

Remove libnotify4 dep as we use shlibs anyway

Sebastien Bacher (seb128) wrote :

reviewing, that change seems fine but some comments on the packaging:
- the current name convention is qtdeclarative5-name<version>, please use that
- the Depends: on libnotify4 is buggy, shlibs take care of that, no need to hardcode the name
- would be nice to put something in the description about the reasons it can't be in the toolkit (is that license, quality, ...)

53. By Łukasz Zemczak on 2013-08-21

Tweak the description a bit

Sebastien Bacher (seb128) wrote :

looks good, thanks for the fixes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-08-20 15:24:49 +0000
3+++ debian/changelog 2013-08-21 08:38:17 +0000
4@@ -1,4 +1,4 @@
5-qtdeclarative5-ubuntu-ui-extras-plugin (0.1-0ubuntu1) UNRELEASED; urgency=low
6+ubuntu-ui-extras (0.1-0ubuntu1) UNRELEASED; urgency=low
7
8 [ Ugo Riboni ]
9 * Initial Release
10
11=== modified file 'debian/control'
12--- debian/control 2013-08-20 20:12:24 +0000
13+++ debian/control 2013-08-21 08:38:17 +0000
14@@ -1,4 +1,4 @@
15-Source: qtdeclarative5-ubuntu-ui-extras-plugin
16+Source: ubuntu-ui-extras
17 Section: x11
18 Priority: optional
19 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
20@@ -27,7 +27,7 @@
21 Vcs-Bzr: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-extras/trunk
22 Vcs-Browser: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-extras/trunk/files
23
24-Package: qtdeclarative5-ubuntu-ui-extras-plugin
25+Package: qtdeclarative5-ubuntu-ui-extras0.1
26 Architecture: any
27 Depends: ${misc:Depends},
28 ${shlibs:Depends},
29@@ -39,8 +39,7 @@
30 qtdeclarative5-friends-plugin,
31 qtdeclarative5-window-plugin,
32 libaccounts-qt5-1,
33- libnotify4,
34 Description: Ubuntu UI Extra Components
35 A collection of UI components that for various reasons can't be included in
36- the main Ubuntu UI toolkit.
37-
38+ the main Ubuntu UI toolkit - mostly because of the level of quality, lack of
39+ documentation and/or lack of automated tests.
40
41=== modified file 'debian/copyright'
42--- debian/copyright 2013-06-05 16:18:44 +0000
43+++ debian/copyright 2013-08-21 08:38:17 +0000
44@@ -1,4 +1,6 @@
45 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
46+Upstream-Name: ubuntu-ui-extras
47+Source: https://launchpad.net/ubuntu-ui-extras
48
49 Files: *
50 Copyright: 2013 Canonical Ltd.

Subscribers

People subscribed via source and target branches