Merge lp:~sil2100/ubuntu-themes/packaging_review into lp:ubuntu-themes

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Ken VanDine
Approved revision: 286
Merged at revision: 285
Proposed branch: lp:~sil2100/ubuntu-themes/packaging_review
Merge into: lp:ubuntu-themes
Diff against target: 101 lines (+25/-15)
3 files modified
debian/changelog (+7/-0)
debian/control (+16/-15)
debian/rules (+2/-0)
To merge this branch: bzr merge lp:~sil2100/ubuntu-themes/packaging_review
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+161687@code.launchpad.net

Commit message

Packaging changes related to compliance with our standards

Description of the change

A packaging review, as always. Just some cosmetic things - the diff is big because of some whitespace mods in the copyright - wrap-and-sort is at fault.
The copyrights seem ok. Deps as well.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
286. By Łukasz Zemczak

No need to fix copyright, too much noise is bad as well

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Better without the diff to debian/copyright, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-12 00:02:23 +0000
3+++ debian/changelog 2013-04-30 21:07:29 +0000
4@@ -1,3 +1,10 @@
5+ubuntu-themes (13.04daily13.04.12-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * debian/control, debian/rules:
8+ - Changes related to compliance to our packaging standards
9+
10+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Tue, 30 Apr 2013 21:11:22 +0200
11+
12 ubuntu-themes (13.04daily13.04.12-0ubuntu1) raring; urgency=low
13
14 * Automatic snapshot from revision 283
15
16=== modified file 'debian/control'
17--- debian/control 2013-03-11 14:46:44 +0000
18+++ debian/control 2013-04-30 21:07:29 +0000
19@@ -6,22 +6,23 @@
20 icon-naming-utils,
21 libmagickcore5-extra,
22 python,
23+ python-rsvg,
24 python-scour,
25- python-rsvg,
26 Standards-Version: 3.9.3
27 Homepage: https://launchpad.net/ubuntu-themes
28 # If you aren't a member of ~ubuntu-art-pkg but need to upload
29 # packaging changes, just go ahead. ~ubuntu-art-pkg will notice
30 # and sync up the code again.
31 Vcs-Bzr: https://code.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk
32+Vcs-Browser: https://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk
33
34 Package: light-themes
35 Architecture: all
36-Depends: ${misc:Depends},
37- ubuntu-mono,
38- gtk2-engines-murrine (>= 0.90.3+git20100810),
39+Depends: gtk2-engines-murrine (>= 0.90.3+git20100810),
40 gtk3-engines-unico (>= 1.0.1-0ubuntu2),
41- humanity-icon-theme
42+ humanity-icon-theme,
43+ ubuntu-mono,
44+ ${misc:Depends},
45 Description: Light Themes (Ambiance and Radiance)
46 Includes matching Ambiance and Radiance themes
47 .
48@@ -32,30 +33,30 @@
49
50 Package: ubuntu-mono
51 Architecture: all
52-Depends: ${misc:Depends},
53+Depends: gnome-icon-theme,
54+ hicolor-icon-theme,
55 humanity-icon-theme,
56- gnome-icon-theme,
57- hicolor-icon-theme,
58+ ${misc:Depends},
59 Description: Ubuntu Mono Icon theme
60 Dark and Light panel icons to make your desktop beautiful.
61
62 Package: ubuntu-artwork
63 Architecture: all
64-Depends: ${misc:Depends},
65+Depends: adium-theme-ubuntu,
66 light-themes,
67 ubuntu-mono,
68 ubuntu-wallpapers,
69- adium-theme-ubuntu,
70+ ${misc:Depends},
71 Description: Ubuntu themes and artwork
72 This package contains the Distributor Logo and pulls in all the
73 other components via Depends.
74
75 Package: ubuntu-mobile-icons
76 Architecture: all
77-Depends: ${misc:Depends},
78- hicolor-icon-theme,
79-Provides: ubuntu-mobile
80-Conflicts: ubuntu-mobile
81-Replaces: ubuntu-mobile
82+Depends: hicolor-icon-theme,
83+ ${misc:Depends},
84+Provides: ubuntu-mobile,
85+Conflicts: ubuntu-mobile,
86+Replaces: ubuntu-mobile,
87 Description: Ubuntu Mobile Icon theme
88 Ubuntu mobile icons used for phone and tablet applications and shell.
89
90=== modified file 'debian/rules'
91--- debian/rules 2012-12-11 16:50:12 +0000
92+++ debian/rules 2013-04-30 21:07:29 +0000
93@@ -2,6 +2,8 @@
94 # Uncomment this to turn on verbose mode.
95 #export DH_VERBOSE=1
96
97+export DPKG_GENSYMBOLS_CHECK_LEVEL=4
98+
99 DEB_VERSION := $(shell dpkg-parsechangelog | egrep '^Version:' | cut -f 2 -d ' ')
100
101 %:

Subscribers

People subscribed via source and target branches