Merge lp:~sil2100/ubuntu-terminal-app/fix_cmake_revno into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Łukasz Zemczak
Status: Merged
Merged at revision: 46
Proposed branch: lp:~sil2100/ubuntu-terminal-app/fix_cmake_revno
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 17 lines (+6/-1)
1 file modified
CMakeLists.txt (+6/-1)
To merge this branch: bzr merge lp:~sil2100/ubuntu-terminal-app/fix_cmake_revno
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Review via email: mp+248352@code.launchpad.net

Commit message

Don't use 'latest' as the BZR_REVNO as it is in no way a proper bzr revision number. Instead, use bzr revno to determine the correct rev as other click projects do.

Description of the change

Don't use 'latest' as the BZR_REVNO as it is in no way a proper bzr revision number. Instead, use bzr revno to determine the correct rev as other click projects do.

Please note that I have no experience in click builds and this solution has been simply copied over from other working core-app projects, so please double-test it before approval.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Thanks Łukasz!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Changed development focus to reboot and will run again...

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-10-25 04:42:31 +0000
3+++ CMakeLists.txt 2015-02-03 10:26:45 +0000
4@@ -41,7 +41,12 @@
5 set(QT_IMPORTS_DIR "/lib/${ARCH_TRIPLET}")
6 set(BIN_DIR /lib/${ARCH_TRIPLET}/bin)
7 if(NOT BZR_REVNO)
8- set(BZR_REVNO "latest")
9+ execute_process(
10+ COMMAND bzr revno
11+ OUTPUT_VARIABLE BZR_REVNO
12+ WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
13+ OUTPUT_STRIP_TRAILING_WHITESPACE
14+ )
15 endif(NOT BZR_REVNO)
16
17 execute_process(

Subscribers

People subscribed via source and target branches