Merge lp:~sil2100/ubuntu-terminal-app/fix_cmake_revno into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Proposed by
Łukasz Zemczak
Status: | Merged |
---|---|
Merged at revision: | 46 |
Proposed branch: | lp:~sil2100/ubuntu-terminal-app/fix_cmake_revno |
Merge into: | lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot |
Diff against target: |
17 lines (+6/-1) 1 file modified
CMakeLists.txt (+6/-1) |
To merge this branch: | bzr merge lp:~sil2100/ubuntu-terminal-app/fix_cmake_revno |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Needs Fixing | |
Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
Review via email: mp+248352@code.launchpad.net |
Commit message
Don't use 'latest' as the BZR_REVNO as it is in no way a proper bzr revision number. Instead, use bzr revno to determine the correct rev as other click projects do.
Description of the change
Don't use 'latest' as the BZR_REVNO as it is in no way a proper bzr revision number. Instead, use bzr revno to determine the correct rev as other click projects do.
Please note that I have no experience in click builds and this solution has been simply copied over from other working core-app projects, so please double-test it before approval.
To post a comment you must log in.
Thanks Łukasz!