Merge lp:~sil2100/ubuntu-seeds/ubuntu-touch-remove-boost-hard-version-dep into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.wily
| Status: | Merged |
|---|---|
| Merged at revision: | 309 |
| Proposed branch: | lp:~sil2100/ubuntu-seeds/ubuntu-touch-remove-boost-hard-version-dep |
| Merge into: | lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.wily |
| Diff against target: |
11 lines (+0/-1) 1 file modified
sdk-libs-dev (+0/-1) |
| To merge this branch: | bzr merge lp:~sil2100/ubuntu-seeds/ubuntu-touch-remove-boost-hard-version-dep |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Steve Langasek | 2015-08-06 | Needs Information on 2015-08-06 | |
|
Review via email:
|
|||
Commit Message
Try not to depend on an explicit boost version in sdk-libs-dev as there are no reasons to do so. This will unblock a few packages and make main boost transitions a bit less painful (seeds won't require bumping with each release).
Description of the Change
Try not to depend on an explicit boost version in sdk-libs-dev as there are no reasons to do so. This will unblock a few packages and make main boost transitions a bit less painful (seeds won't require bumping with each release).
Currently this blocks many packages from migrating to the release pocket. The issue is that currently sdk-libs-dev deps on libboost1.55-dev. The main seed branch had this dep bumped to libboost1.58-dev but this is still in -proposed (and the transition will take a long time to finish). There's no real reason to depend on a specific version here, so we can simply use the dependency package instead. There should be no consequences of this change (besides the positive ones)
| Łukasz Zemczak (sil2100) wrote : | # |
That is a valid point. Checking the dependencies, boost should be pulled in by libunity-scopes-dev in sdk-libs-dev. This pulls in libunity-api-dev which depends on libboost-dev. I see no other point on depending on it here. If that's fine, I'll remove this dependency at all as you proposed.
- 310. By Łukasz Zemczak on 2015-08-06
-
As per Steve's proposition, we can simply remove the libboost dep altogether as it's being pulled in by scopes deps.
If there's no reason to depend on a specific version of boost, why do we depend on it at all? I understand the argument for why we shouldn't be depending on a specific boost version is that the boost interfaces should not be directly exposed as part of our SDK. "Not exposed" == "not depended upon".