Merge lp:~sil2100/ubuntu-cdimage/uc-rebuild-requests into lp:ubuntu-cdimage

Proposed by Łukasz Zemczak
Status: Merged
Merged at revision: 2059
Proposed branch: lp:~sil2100/ubuntu-cdimage/uc-rebuild-requests
Merge into: lp:ubuntu-cdimage
Diff against target: 25 lines (+11/-2)
1 file modified
bin/rebuild-requests (+11/-2)
To merge this branch: bzr merge lp:~sil2100/ubuntu-cdimage/uc-rebuild-requests
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+424207@code.launchpad.net

Commit message

rebuild-requests: Add support for Ubuntu Core image rebuilds

Description of the change

rebuild-requests: Add support for Ubuntu Core image rebuilds

Tested this in a hacky way and it seems to be doing what it should. All because ubuntu-core is a very special snowflake.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Kinda ugly but makes sense.

review: Needs Fixing
2060. By Łukasz Zemczak

Use entry[2] as proposed by vorlon

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thanks for the review! I changed the env['CHANNEL'] entry and will now merge it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/rebuild-requests'
2--- bin/rebuild-requests 2022-05-04 12:23:22 +0000
3+++ bin/rebuild-requests 2022-06-09 08:31:20 +0000
4@@ -188,10 +188,19 @@
5 env['ARCHES'] = arches
6 env['DIST'] = entries[0][0].series_title.lower()
7
8- # The ubuntu-base image is actually hacked up in overall, so even
9- # though it's defined as "daily", it's a "daily-live" type
10 image_type = entry[2]
11 if project == "ubuntu-base":
12+ # The ubuntu-base image is actually hacked up in overall, so
13+ # even though it's defined as "daily", it's a "daily-live" type
14+ image_type = "daily-live"
15+ elif project in ("ubuntu-core", "ubuntu-appliance"):
16+ # The ubuntu-core images however are also a bit special, as
17+ # they have a different publish structure, CHANNEL arguments
18+ # and more
19+ env['EXTRA_PPAS'] = "snappy-dev/image"
20+ # Due to the different structure, IMAGE_TYPE is the channel
21+ # here
22+ env['CHANNEL'] = entry[2]
23 image_type = "daily-live"
24
25 cmd = ["for-project", project, "cron.%s" % image_type]

Subscribers

People subscribed via source and target branches