Merge lp:~sil2100/ubuntu-cdimage/latest-unique_key into lp:ubuntu-cdimage

Proposed by Łukasz Zemczak
Status: Merged
Merged at revision: 1777
Proposed branch: lp:~sil2100/ubuntu-cdimage/latest-unique_key
Merge into: lp:ubuntu-cdimage
Diff against target: 11 lines (+1/-0)
1 file modified
lib/cdimage/launchpad.py (+1/-0)
To merge this branch: bzr merge lp:~sil2100/ubuntu-cdimage/latest-unique_key
Reviewer Review Type Date Requested Status
Ubuntu CD Image Team Pending
Review via email: mp+361685@code.launchpad.net

Commit message

When fetching latest livefs build from list of completed builds, key also on the unique_key if it's supplied.

Description of the change

When fetching latest livefs build from list of completed builds, key also on the unique_key if it's supplied.

Without this change, in cases where there's multiple subarch builds for one project and arch, cdimage could fetch the wrong livefs build as no unique_key matching was being done.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/cdimage/launchpad.py'
2--- lib/cdimage/launchpad.py 2015-10-26 11:06:11 +0000
3+++ lib/cdimage/launchpad.py 2019-01-11 17:48:00 +0000
4@@ -117,6 +117,7 @@
5 # completed build for this DAS.
6 for build in self.completed_builds:
7 if (build.distro_arch_series == distro_arch_series and
8+ (not unique_key or build.unique_key == unique_key) and
9 build.buildstate == "Successfully built"):
10 self._current_build_cache[archtag][unique_key] = build
11 break

Subscribers

People subscribed via source and target branches