ubuntu-archive-tools

Merge lp:~sil2100/ubuntu-archive-tools/sru-report-blocked-proposed into lp:ubuntu-archive-tools

  1. sru-report-blocked-proposed
  2. Merge into trunk
Proposed by Łukasz Zemczak
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 1233
Merged at revision: 1232
Proposed branch: lp:~sil2100/ubuntu-archive-tools/sru-report-blocked-proposed
Merge into: lp:ubuntu-archive-tools
Diff against target: 35 lines (+10/-1)
1 file modified
sru-report (+10/-1)
To merge this branch: bzr merge lp:~sil2100/ubuntu-archive-tools/sru-report-blocked-proposed
Reviewer Review Type Date Requested Status
Brian Murray Approve
Steve Langasek Approve
Review via email: mp+370867@code.launchpad.net

Commit message

Support block-proposed in sru-report.

Description of the change

Support block-proposed in sru-report.

Context: we decided to allow staging uploads in -proposed, for instance if an upload has autopkgtest-only fixes or some other changes that do not make sense to be released on their own. Such bugs can be verified normally while still being block-proposed. To make life easier, I propose adding a visual change to sru-report to mark such bugs so that it's easier visible for sru members. Otherwise someone can not read the description of the bug and release the SRU by accident.

In my opinion it makes more sense to do that here than in sru-release, since sru-release always seemed to me like a 'no input required' tool. Adding a prompt there on block-proposed feels like a bad fit.
But in case more SRU members prefer that in sru-release, I can add a prompt there instead.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

LGTM. I'd like Brian's review also.

review: Approve
Revision history for this message
Brian Murray (brian-murray) wrote :

The asterisk seemed really subtle to me when I was reviewing the report, I'd prefer replacing it with an emoji (xnox!). I'd suggest U+1F6A7 which is "often used to physically block access".

review: Needs Fixing
lp:~sil2100/ubuntu-archive-tools/sru-report-blocked-proposed updated
1233. By Łukasz Zemczak

As proposed by Brian, use a more representative unicode character for the blocked indicator.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thanks Steve, Brian! I have switched to the silly emoji sign as proposed by Brian. Looks 'decent'.

Revision history for this message
Brian Murray (brian-murray) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sru-report'
2--- sru-report 2019-06-19 07:12:50 +0000
3+++ sru-report 2019-08-02 08:01:13 +0000
4@@ -206,6 +206,7 @@
5 a.testing { color: blue; }
6 a.broken { text-decoration: line-through; color: black; }
7 a.removal { color: gray; font-weight: bold }
8+ a.blockproposed:after { content: "\\1F6A7"; font-weight: normal; }
9 </style>
10 </head>
11 <body>
12@@ -243,7 +244,10 @@
13 bugs and bugs that are
14 <span style="text-decoration: line-through;">struck through</span> are
15 duplicate bug reports or weren't accessible at the time the report was
16-generated.</p>''')
17+generated. Bugs with the &#x1F6A7; character next to their number are bugs with
18+a block-proposed tag, indicating that they should not be released without
19+double-checking the bug contents. Those can be staged in -proposed, even
20+when verified, for a reason.</p>''')
21
22 #
23 # pending SRUs
24@@ -434,6 +438,11 @@
25 # people who don't use lp anymore
26 if error.response['status'] == '410':
27 continue
28+ # We now also try handling block-proposed tags for updates
29+ # that can be verified but should not be released yet for
30+ # some reasons.
31+ if 'block-proposed' in t:
32+ cls += ' blockproposed'
33 cls += '"'
34
35 print('<a href="%s/bugs/%d" '

Subscribers

People subscribed via source and target branches