Merge lp:~sil2100/ubuntu-archive-tools/in-progress-kernels into lp:ubuntu-archive-tools

Proposed by Łukasz Zemczak on 2017-06-30
Status: Merged
Merged at revision: 1108
Proposed branch: lp:~sil2100/ubuntu-archive-tools/in-progress-kernels
Merge into: lp:ubuntu-archive-tools
Diff against target: 21 lines (+11/-0)
1 file modified
kernel-sru-review (+11/-0)
To merge this branch: bzr merge lp:~sil2100/ubuntu-archive-tools/in-progress-kernels
Reviewer Review Type Date Requested Status
Steve Langasek 2017-06-30 Needs Fixing on 2017-06-30
Review via email: mp+326584@code.launchpad.net

Commit Message

Add a check to kernel-sru-review that allows processing of promote-to-proposed In Progress bugs.

Description of the Change

Add a check to kernel-sru-review that allows processing of promote-to-proposed In Progress bugs.

This basically checks if the In Progress task is assigned to the person running the tool. If yes, we continue, if not then it asks if the user is sure about that - since someone else might be working on it.

To post a comment you must log in.
1105. By Łukasz Zemczak on 2017-06-30

Whoops, typo

Steve Langasek (vorlon) wrote :

+1 with modifications

review: Needs Fixing
1106. By Łukasz Zemczak on 2017-07-04

Change wording, wrap lines.

Łukasz Zemczak (sil2100) wrote :

Steve, could you take a look if with these changes it's good to go?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'kernel-sru-review'
2--- kernel-sru-review 2017-03-17 12:17:00 +0000
3+++ kernel-sru-review 2017-07-04 15:47:05 +0000
4@@ -50,6 +50,17 @@
5 return {}
6 if task.status == 'Confirmed':
7 return {'proposed': task}
8+ elif task.status == 'In Progress':
9+ if lp.me.self_link != task.assignee_link:
10+ print("This bug is in progress and not assigned to you. Do you "
11+ "still want to review \nit? [yN]".
12+ end="")
13+ sys.stdout.flush()
14+ response = sys.stdin.readline()
15+ if not response.strip().lower().startswith('y'):
16+ raise KernelWorkflowError("Skipping bug %s" % bugnum)
17+ return {'proposed': task}
18+
19 raise KernelWorkflowError(
20 "Ignoring bug %s, not ready to promote-to-proposed"
21 % bugnum)

Subscribers

People subscribed via source and target branches