Merge lp:~sil2100/qtubuntu-cameraplugin-fake/remove_tests_fix_lintian into lp:qtubuntu-cameraplugin-fake

Proposed by Łukasz Zemczak
Status: Merged
Merged at revision: 35
Proposed branch: lp:~sil2100/qtubuntu-cameraplugin-fake/remove_tests_fix_lintian
Merge into: lp:qtubuntu-cameraplugin-fake
Diff against target: 59 lines (+7/-15)
4 files modified
debian/cameraplugin-fake-tests.install (+0/-1)
debian/cameraplugin-fake.install (+0/-2)
debian/control (+4/-9)
unittests/storagemanager/storagemanager.pro (+3/-3)
To merge this branch: bzr merge lp:~sil2100/qtubuntu-cameraplugin-fake/remove_tests_fix_lintian
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ken VanDine Approve
Review via email: mp+175329@code.launchpad.net

Commit message

Fix lintian errors. Do not install tests, remove the -tests package as we don't need unit tests installed on the user's system

Description of the change

Fix lintian errors. Do not install tests, remove the -tests package as we don't need unit tests installed on the user's system

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Since it's dropping a binary package, it would probably be best to force removal of that package for anyone that might have installed it.

review: Needs Fixing
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Great, thanks

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'debian/cameraplugin-fake-tests.install'
2--- debian/cameraplugin-fake-tests.install 2013-03-28 18:32:22 +0000
3+++ debian/cameraplugin-fake-tests.install 1970-01-01 00:00:00 +0000
4@@ -1,1 +0,0 @@
5-usr/share/fakeCamera/tst_*
6
7=== removed file 'debian/cameraplugin-fake.install'
8--- debian/cameraplugin-fake.install 2013-03-28 18:32:22 +0000
9+++ debian/cameraplugin-fake.install 1970-01-01 00:00:00 +0000
10@@ -1,2 +0,0 @@
11-usr/lib/*
12-usr/share/fakeCamera/*.jpg
13
14=== modified file 'debian/control'
15--- debian/control 2013-04-25 13:41:29 +0000
16+++ debian/control 2013-07-17 17:09:24 +0000
17@@ -3,8 +3,7 @@
18 Priority: optional
19 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
20 Build-Depends: debhelper (>= 9),
21- libgl-dev,
22- libgles2-mesa-dev,
23+ libgles2-mesa-dev | libgl1-mesa-dev,
24 libpulse-dev,
25 pkg-config,
26 qt5-default,
27@@ -17,15 +16,11 @@
28 Vcs-Bzr: https://code.launchpad.net/~phablet-team/qtubuntu-cameraplugin-fake/trunk
29
30 Package: cameraplugin-fake
31-Architecture: i386 amd64 armhf
32+Architecture: any
33 Depends: ${misc:Depends},
34 ${shlibs:Depends},
35+Conflicts: cameraplugin-fake-tests
36+Breaks: cameraplugin-fake-tests
37 Description: Camera plugin for QtMultimedia faking with a photo file
38 A plugin for QtMultimedia faking a real camera by using
39 an image from disk as source of the photo.
40-
41-Package: cameraplugin-fake-tests
42-Architecture: i386 amd64 armhf
43-Depends: ${misc:Depends},
44- ${shlibs:Depends},
45-Description: Unit tests for cameraplugin-fake
46
47=== modified file 'unittests/storagemanager/storagemanager.pro'
48--- unittests/storagemanager/storagemanager.pro 2013-03-28 18:32:22 +0000
49+++ unittests/storagemanager/storagemanager.pro 2013-07-17 17:09:24 +0000
50@@ -8,6 +8,6 @@
51
52 INCLUDEPATH += ../../src
53
54-target.path = /usr/share/fakeCamera
55-
56-INSTALLS += target
57+# The testcase config forces an INSTALLS of the tests, so we have to
58+# explicitly inform it that we do not want the tests installed
59+target.CONFIG += no_default_install

Subscribers

People subscribed via source and target branches