Merge lp:~sil2100/python-ubuntu-platform-api/packaging_review into lp:python-ubuntu-platform-api

[Łukasz Zemczak]

Modifications related to compliance with our packaging standards

Packaging review. Modifications related to compliance with our packaging standards

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:9
http://jenkins.qa.ubuntu.com/job/python-upa-ci/11/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/python-upa-saucy-armhf-ci/15

Click here to trigger a rebuild:
http://s-jenkins:8080/job/python-upa-ci/11/rebuild

review: Approve (continuous-integration)

[Timo Jyrinki (timo-jyrinki)]

Package priority optional (not extra), use debhelper 9 if no reason not to use it. COPYING missing, as is license headers from the code file(s). README is not needed in debian/. Remove template comments from rules.

review: Needs Fixing

[lp:~sil2100/python-ubuntu-platform-api/packaging_review]

10. By Łukasz Zemczak on 2013-06-10

README unneeded

[Timo Jyrinki (timo-jyrinki)]

Ok, correction after checking out the correct branch, not the unfixed one :)

- add copyright headers to the code file and the two .py files?
- remove README
- remove template text from debian/rules

[lp:~sil2100/python-ubuntu-platform-api/packaging_review]

11. By Łukasz Zemczak on 2013-06-10

Missed some sample comments

12. By Łukasz Zemczak on 2013-06-10

Ooops, forgot something at the comment

13. By Łukasz Zemczak on 2013-06-10

Use the ubuntu.com e-mail

[Timo Jyrinki (timo-jyrinki)]

(with revision 12) getting Lintian errors/warnings/informations, seem largely valid (override with lintian overrides if not fixing some):

W: python-ubuntu-platform-api source: native-package-with-dash-version
W: python-ubuntu-platform-api source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
I: python-ubuntu-platform-api: description-synopsis-might-not-be-phrased-properly
I: python-ubuntu-platform-api: extended-description-is-probably-too-short
I: python-ubuntu-platform-api: capitalization-error-in-description python Python
W: python-ubuntu-platform-api: wrong-section-according-to-package-name python-ubuntu-platform-api => python
W: python-ubuntu-platform-api: script-with-language-extension usr/bin/monitor_upa.py
W: python-ubuntu-platform-api: binary-without-manpage usr/bin/monitor_upa.py
E: python-ubuntu-platform-api: python-script-but-no-python-dep usr/bin/monitor_upa.py

with long descriptions at http://pastebin.ubuntu.com/5752025/

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:11
http://jenkins.qa.ubuntu.com/job/python-upa-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/python-upa-saucy-armhf-ci/16

Click here to trigger a rebuild:
http://s-jenkins:8080/job/python-upa-ci/12/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:13
http://jenkins.qa.ubuntu.com/job/python-upa-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/python-upa-saucy-armhf-ci/17

Click here to trigger a rebuild:
http://s-jenkins:8080/job/python-upa-ci/13/rebuild

review: Approve (continuous-integration)

[lp:~sil2100/python-ubuntu-platform-api/packaging_review]

14. By Łukasz Zemczak on 2013-06-10

Fix some lintian errors

15. By Łukasz Zemczak on 2013-06-10

Remove the source/format file, switch from devel to python

[Łukasz Zemczak (sil2100)]

Ok, I fixed most of the issues. Others seem to be simply nit-picks which I think we should ignore. Lintian overrides is one way, but I think we could leave this as it is, not 'hiding' those warnings.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:15
http://jenkins.qa.ubuntu.com/job/python-upa-ci/14/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/python-upa-saucy-armhf-ci/18

Click here to trigger a rebuild:
http://s-jenkins:8080/job/python-upa-ci/14/rebuild

review: Approve (continuous-integration)

[Timo Jyrinki (timo-jyrinki)]

Starts to look good now! All errors and all warnings except for man page warning fixed, among with other issues.

review: Approve