Merge lp:~sil2100/notes-app/rename_libhud-qt_and_hud1 into lp:notes-app

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Ken VanDine
Approved revision: 107
Merged at revision: 107
Proposed branch: lp:~sil2100/notes-app/rename_libhud-qt_and_hud1
Merge into: lp:notes-app
Diff against target: 36 lines (+5/-3)
2 files modified
NotesApp.qml (+4/-2)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~sil2100/notes-app/rename_libhud-qt_and_hud1
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ken VanDine Approve
Review via email: mp+160711@code.launchpad.net

Commit message

libhud-qt-qml has been renamed to qtdeclarative5-hud1.0. Also, switch code to use HUD 1.0

Description of the change

- Problem:

libhud-qt got renamed to libhud-qt1 and libhud-qt-qml to qtdeclarative5-hud1.0. Deps need to be modified.
Also, we now have HUD 1.0 in QML.

- Fix:

Rename libhud-qt-qml. Fix to use HUD 1.0 in QML.

- Tests:

N/A

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Great

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NotesApp.qml'
2--- NotesApp.qml 2013-04-17 13:07:43 +0000
3+++ NotesApp.qml 2013-04-24 17:12:30 +0000
4@@ -17,7 +17,7 @@
5 import QtQuick 2.0
6 import Ubuntu.Components 0.1
7 import Ubuntu.Components.ListItems 0.1 as ListItem
8-import Ubuntu.HUD 0.1 as HUD
9+import Ubuntu.HUD 1.0 as HUD
10 import NotesApp.Plugins 0.1
11 import "Components"
12 import "Models"
13@@ -30,7 +30,9 @@
14 HUD.HUD {
15 applicationIdentifier: "notes-app" // this has to match the .desktop file!
16 HUD.Context {
17- toolbar.quitAction.onTriggered: Qt.quit()
18+ HUD.QuitAction {
19+ onTriggered: Qt.quit()
20+ }
21 HUD.Action {
22 label: "Add"
23 keywords: "Create New Note"
24
25=== modified file 'debian/control'
26--- debian/control 2013-04-17 20:01:51 +0000
27+++ debian/control 2013-04-24 17:12:30 +0000
28@@ -17,7 +17,7 @@
29 Depends: ${misc:Depends},
30 qmlscene,
31 qtdeclarative5-ubuntu-ui-toolkit-plugin,
32- libhud-qt-qml,
33+ qtdeclarative5-hud1.0,
34 qtdeclarative5-qtquick2-plugin,
35 qtdeclarative5-localstorage-plugin,
36 libqt5sql5-sqlite,

Subscribers

People subscribed via source and target branches