Merge lp:~sil2100/notes-app/packaging_review into lp:notes-app

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 110
Merged at revision: 108
Proposed branch: lp:~sil2100/notes-app/packaging_review
Merge into: lp:notes-app
Diff against target: 90 lines (+27/-16)
4 files modified
debian/changelog (+6/-0)
debian/compat (+1/-1)
debian/control (+19/-14)
debian/notes-app.install (+1/-1)
To merge this branch: bzr merge lp:~sil2100/notes-app/packaging_review
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+160866@code.launchpad.net

Commit message

Do some packaging review changes. Add a bootstrapping commit

Description of the change

Do a packaging review for inclusion to the daily process. We're following the guidelines.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Could you please add Vcs-Browser as well (since it's simple to add, same as Vcs-Bzr but s/code/bazaar/ and add "/files" at the end).

I also wish the long description (what goes below the Description: line) was a little longer, but that's just nitpicking.

review: Needs Fixing
109. By Łukasz Zemczak

Added Vcs-Browser as well

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
110. By Łukasz Zemczak

Make the package description a *bit* better

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-09 16:18:37 +0000
3+++ debian/changelog 2013-04-25 16:18:31 +0000
4@@ -1,3 +1,9 @@
5+notes-app (1.4-0ubuntu1) UNRELEASED; urgency=low
6+
7+ * Automatic snapshot from revision 107 (bootstrap)
8+
9+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Thu, 25 Apr 2013 13:32:36 +0200
10+
11 notes-app (1.4) quantal; urgency=low
12
13 * Ensure text focus is correct in all cases (LP: #1163778)
14
15=== modified file 'debian/compat'
16--- debian/compat 2012-12-21 09:05:51 +0000
17+++ debian/compat 2013-04-25 16:18:31 +0000
18@@ -1,1 +1,1 @@
19-8
20+9
21
22=== modified file 'debian/control'
23--- debian/control 2013-04-24 17:08:09 +0000
24+++ debian/control 2013-04-25 16:18:31 +0000
25@@ -1,36 +1,41 @@
26 Source: notes-app
27-Priority: extra
28+Priority: optional
29 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
30 XSBC-Original-Maintainer: Ugo Riboni <ugo.riboni@canonical.com>
31-Build-Depends: debhelper (>= 9.0.0),
32+Build-Depends: cmake,
33+ debhelper (>= 9),
34 python (>= 2.7),
35- cmake,
36 qtbase5-dev,
37 qtdeclarative5-dev,
38 Standards-Version: 3.9.2
39 Section: libs
40-Vcs-Bzr: lp:notes-app
41+Homepage: https://launchpad.net/notes-app
42+# If you aren't a member of ~phablet-team but need to upload packaging changes,
43+# just go ahead. ~phablet-team will notice and sync up the code again.
44+Vcs-Bzr: https://code.launchpad.net/~phablet-team/notes-app/trunk
45+Vcs-Browser: https://bazaar.launchpad.net/~phablet-team/notes-app/trunk/files
46
47 Package: notes-app
48 Section: devel
49 Architecture: any
50-Depends: ${misc:Depends},
51+Depends: libqt5sql5-sqlite,
52 qmlscene,
53- qtdeclarative5-ubuntu-ui-toolkit-plugin,
54 qtdeclarative5-hud1.0,
55+ qtdeclarative5-localstorage-plugin,
56 qtdeclarative5-qtquick2-plugin,
57- qtdeclarative5-localstorage-plugin,
58- libqt5sql5-sqlite,
59+ qtdeclarative5-ubuntu-ui-toolkit-plugin,
60+ ${misc:Depends},
61 Description: Notes application
62- Allows taking notes
63+ notes-app is a note taking application for the Ubuntu platform.
64
65 Package: notes-app-autopilot
66 Architecture: all
67-Depends: ${misc:Depends},
68- python2.7,
69- notes-app (= ${source:Version}),
70- libautopilot-qt,
71+Depends: libautopilot-qt,
72 libqt5test5,
73 libqt5widgets5,
74+ notes-app (= ${source:Version}),
75+ python2.7,
76+ ${misc:Depends},
77 Description: Test package for the notes app
78- Autopilot tests for the notes app package
79+ notes-app is a note taking application for the Ubuntu platform. This package
80+ contains autopilot tests for it.
81
82=== modified file 'debian/notes-app.install'
83--- debian/notes-app.install 2013-04-22 09:10:50 +0000
84+++ debian/notes-app.install 2013-04-25 16:18:31 +0000
85@@ -1,4 +1,4 @@
86 usr/bin/notes-app
87+usr/lib/*/qt5/qml/NotesApp
88 usr/share/applications/notes-app.desktop
89 usr/share/notes-app
90-usr/lib/*/qt5/qml/NotesApp

Subscribers

People subscribed via source and target branches