Merge lp:~sil2100/libsignon-glib/fix_linking_again into lp:libsignon-glib
Proposed by
Łukasz Zemczak
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | 148 |
Merged at revision: | 148 |
Proposed branch: | lp:~sil2100/libsignon-glib/fix_linking_again |
Merge into: | lp:libsignon-glib |
Diff against target: |
13 lines (+2/-1) 1 file modified
tests/Makefile.am (+2/-1) |
To merge this branch: | bzr merge lp:~sil2100/libsignon-glib/fix_linking_again |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+171027@code.launchpad.net |
Commit message
Previous fix was not enough, we need to add manually pthread as it's not linked, because the toolchain, quoting, 'only links with needed libraries'
Description of the change
Previous fix was not enough, we need to add manually pthread as it's not linked, because the toolchain, quoting, 'only links with needed libraries'.
The last fix did not work properly. I had a misunderstanding with the configure.ac, and in fact that change was not fixing anything, but because of a typo I made in configure it simply disabled the tests. This typo did not get 'into' trunk luckily.
This change, on the other hand, works - it's not beautiful, but unblocks trunk at least.
To post a comment you must log in.
PASSED: Continuous integration, rev:148 jenkins. qa.ubuntu. com/job/ libsignon- glib-ci/ 7/ jenkins. qa.ubuntu. com/job/ libsignon- glib-saucy- amd64-ci/ 2
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ libsignon- glib-ci/ 7/rebuild
http://