Merge lp:~sil2100/libdbusmenu-qt/packaging_review into lp:libdbusmenu-qt

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 244
Merged at revision: 244
Proposed branch: lp:~sil2100/libdbusmenu-qt/packaging_review
Merge into: lp:libdbusmenu-qt
Diff against target: 129 lines (+39/-20)
3 files modified
debian/changelog (+7/-0)
debian/control (+30/-20)
debian/rules (+2/-0)
To merge this branch: bzr merge lp:~sil2100/libdbusmenu-qt/packaging_review
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+162117@code.launchpad.net

Commit message

Modifications related to compliance with our packaging standards

Description of the change

Packaging review. Modifications related to compliance with our packaging standards

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-03 14:16:01 +0000
3+++ debian/changelog 2013-05-02 15:33:28 +0000
4@@ -1,3 +1,10 @@
5+libdbusmenu-qt (0.9.2daily13.03.28-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * debian/control, debian/rules:
8+ - Modifications related to compliance with our packaging standards
9+
10+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Thu, 02 May 2013 17:29:01 +0200
11+
12 libdbusmenu-qt (0.9.2daily13.03.28-0ubuntu1) raring; urgency=low
13
14 [ Łukasz 'sil2100' Zemczak ]
15
16=== modified file 'debian/control'
17--- debian/control 2013-03-28 19:06:30 +0000
18+++ debian/control 2013-05-02 15:33:28 +0000
19@@ -1,26 +1,26 @@
20 Source: libdbusmenu-qt
21 Section: libs
22 Priority: optional
23-Build-Depends:
24- cmake (>= 2.8.5),
25- debhelper (>= 9),
26- doxygen,
27- libqjson-dev,
28- libqt4-dev,
29- qtbase5-dev,
30+Build-Depends: cmake (>= 2.8.5),
31+ debhelper (>= 9),
32+ doxygen,
33+ libqjson-dev,
34+ libqt4-dev,
35+ qtbase5-dev,
36 Maintainer: Kubuntu Developers <kubuntu-devel@lists.ubuntu.com>
37 XSBC-Original-Maintainer: Jonathan Riddell <jriddell@ubuntu.com>
38 Standards-Version: 3.9.4
39 Homepage: https://launchpad.net/libdbusmenu-qt
40-# If you aren't ~indicator-applet-developers but need to upload packaging changes,
41-# just go ahead. ~indicator-applet-developers will notice and sync up the code again.
42-Vcs-Bzr: https://code.launchpad.net/~indicator-applet-developers/appmenu-qt/trunk
43-Vcs-Browser: https://bazaar.launchpad.net/~indicator-applet-developers/appmenu-qt/trunk/files
44+# If you aren't ~dbusmenu-team but need to upload packaging changes,
45+# just go ahead. ~dbusmenu-team will notice and sync up the code again.
46+Vcs-Bzr: https://code.launchpad.net/~dbusmenu-team/libdbusmenu-qt/trunk
47+Vcs-Browser: https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu-qt/trunk/files
48
49 Package: libdbusmenu-qt2
50 Architecture: any
51-Pre-Depends: ${misc:Pre-Depends}
52-Depends: ${misc:Depends}, ${shlibs:Depends}
53+Pre-Depends: ${misc:Pre-Depends},
54+Depends: ${misc:Depends},
55+ ${shlibs:Depends},
56 Multi-Arch: same
57 Description: Qt implementation of the DBusMenu protocol
58 This library provides a Qt implementation of the DBusMenu protocol.
59@@ -32,9 +32,13 @@
60
61 Package: libdbusmenu-qt5
62 Architecture: any
63-Pre-Depends: ${misc:Pre-Depends}
64-Depends: ${misc:Depends}, ${shlibs:Depends}
65-Suggests: libqt5core5, libqt5dbus5, libqt5gui5, libqt5widgets5
66+Pre-Depends: ${misc:Pre-Depends},
67+Depends: ${misc:Depends},
68+ ${shlibs:Depends},
69+Suggests: libqt5core5,
70+ libqt5dbus5,
71+ libqt5gui5,
72+ libqt5widgets5,
73 Multi-Arch: same
74 Description: Qt5 implementation of the DBusMenu protocol
75 This library provides a Qt5 implementation of the DBusMenu protocol.
76@@ -47,7 +51,9 @@
77 Package: libdbusmenu-qt-dev
78 Section: libdevel
79 Architecture: any
80-Depends: libdbusmenu-qt2 (= ${binary:Version}), libqt4-dev, ${misc:Depends}
81+Depends: libdbusmenu-qt2 (= ${binary:Version}),
82+ libqt4-dev,
83+ ${misc:Depends},
84 Description: Qt implementation of the DBusMenu protocol (development)
85 This library provides a Qt implementation of the DBusMenu protocol.
86 .
87@@ -59,7 +65,9 @@
88 Package: libdbusmenu-qt5-dev
89 Section: libdevel
90 Architecture: any
91-Depends: libdbusmenu-qt5 (= ${binary:Version}), qtbase5-dev, ${misc:Depends}
92+Depends: libdbusmenu-qt5 (= ${binary:Version}),
93+ qtbase5-dev,
94+ ${misc:Depends},
95 Description: Qt5 implementation of the DBusMenu protocol (development)
96 This library provides a Qt5 implementation of the DBusMenu protocol.
97 .
98@@ -71,7 +79,8 @@
99 Package: libdbusmenu-qt-doc
100 Section: doc
101 Architecture: all
102-Depends: libjs-jquery, ${misc:Depends}
103+Depends: libjs-jquery,
104+ ${misc:Depends},
105 Description: Qt implementation of the DBusMenu protocol (documentation)
106 This library provides a Qt implementation of the DBusMenu protocol.
107 .
108@@ -83,7 +92,8 @@
109 Package: libdbusmenu-qt5-doc
110 Section: doc
111 Architecture: all
112-Depends: libjs-jquery, ${misc:Depends}
113+Depends: libjs-jquery,
114+ ${misc:Depends},
115 Description: Qt5 implementation of the DBusMenu protocol (documentation)
116 This library provides a Qt5 implementation of the DBusMenu protocol.
117 .
118
119=== modified file 'debian/rules'
120--- debian/rules 2013-03-28 18:01:24 +0000
121+++ debian/rules 2013-05-02 15:33:28 +0000
122@@ -3,6 +3,8 @@
123 # Uncomment this to turn on verbose mode.
124 #export DH_VERBOSE=1
125
126+export DPKG_GENSYMBOLS_CHECK_LEVEL=4
127+
128 %:
129 dh $@ --parallel --buildsystem=cmake
130

Subscribers

People subscribed via source and target branches