Code review comment for lp:~sil2100/kubuntu-packaging/qtbase-opensource-src_appmenu-qt5_support

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks good, amd64 and i386 practically finished: https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-daily/+sourcepub/3741335/+listing-archive-extra and there should be no reason why armhf should be failed.

But I need to do another upload since I forgot to enable the debug flags from the build which is wanted for PPA builds. Merging anyhow. It will reside in qt5-daily for the moment, and will be then copied later to qt5-beta2 again where the rest lies.

review: Approve

« Back to merge proposal