Merge lp:~sil2100/indicator-appmenu/indicator-appmenu-qt5 into lp:indicator-appmenu/13.10
Status: | Merged |
---|---|
Approved by: | Mathieu Trudel-Lapierre |
Approved revision: | 236 |
Merged at revision: | 236 |
Proposed branch: | lp:~sil2100/indicator-appmenu/indicator-appmenu-qt5 |
Merge into: | lp:indicator-appmenu/13.10 |
Diff against target: |
26 lines (+8/-0) 2 files modified
debian/changelog (+7/-0) debian/control (+1/-0) |
To merge this branch: | bzr merge lp:~sil2100/indicator-appmenu/indicator-appmenu-qt5 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+156017@code.launchpad.net |
Commit message
We're adding Qt5 support to appmenu, let's pull that in case someone would install Qt5. It's safe, since the added packages don't depend on Qt5 directly - they Suggest it instead.
Description of the change
NOTE! There are a few merges that need to get in before this one can be accepted, be sure to check them before approving!
-> https:/
-> https:/
-> https:/
- Problem:
We lack Qt5 appmenu support. We're adding that. We want to Recommend appmenu-qt5 to have it installed in case Qt5 would be installed by anyone.
- Fix:
We add it to Recommends:. This is safe, since appmenu-qt5 and libdbusmenu-qt5 are hacked not to Depend on Qt5. Instead they 'Suggest' on Qt5. This way, we can safely Recommend those packages and feel safe that Qt5 won't get installed when not needed.
- Tests:
N/A
PASSED: Continuous integration, rev:236 jenkins. qa.ubuntu. com/job/ indicator- appmenu- ci/1/ jenkins. qa.ubuntu. com/job/ indicator- appmenu- raring- amd64-ci/ 1
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ indicator- appmenu- ci/1/rebuild
http://