Merge lp:~sil2100/gnome-control-center-unity/packaging_review into lp:gnome-control-center-unity

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Ken VanDine
Approved revision: 20
Merged at revision: 19
Proposed branch: lp:~sil2100/gnome-control-center-unity/packaging_review
Merge into: lp:gnome-control-center-unity
Diff against target: 61 lines (+15/-6)
4 files modified
debian/changelog (+8/-0)
debian/control (+5/-4)
debian/rules (+2/-0)
debian/watch (+0/-2)
To merge this branch: bzr merge lp:~sil2100/gnome-control-center-unity/packaging_review
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+161529@code.launchpad.net

Commit message

Do packaging changes related to compliance with our packaging standards

Description of the change

Do a packaging review to get gnome-control-center-unity complying to our standards. We can then transition it to head and raring.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Your changes look good, but maybe this would be a good time to remove the commented out build dep for libsocialweb-client-dev

review: Needs Fixing
20. By Łukasz Zemczak

Remove the commented out dependency

Revision history for this message
Ken VanDine (ken-vandine) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-09 00:01:46 +0000
3+++ debian/changelog 2013-04-30 00:11:28 +0000
4@@ -1,3 +1,11 @@
5+gnome-control-center-unity (1.3-0ubuntu1) UNRELEASED; urgency=low
6+
7+ * debian/control, debian/rules:
8+ - Do packaging changes related to compliance with our standards
9+ * Remove debian/watch
10+
11+ -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Mon, 29 Apr 2013 23:40:28 +0200
12+
13 gnome-control-center-unity (1.2daily13.04.09-0ubuntu1) raring; urgency=low
14
15 [ Sebastien Bacher ]
16
17=== modified file 'debian/control'
18--- debian/control 2013-02-13 14:12:21 +0000
19+++ debian/control 2013-04-30 00:11:28 +0000
20@@ -17,17 +17,18 @@
21 libgnome-desktop-3-dev,
22 libgtk-3-dev (>= 3.5.13),
23 libnotify-dev (>= 0.7.3),
24-# libsocialweb-client-dev,
25 libxml2-dev,
26+Homepage: https://launchpad.net/gnome-control-center-unity
27 # If you aren't a member of ~unity-team but need to upload packaging changes,
28 # just go ahead. ~unity-team will notice and sync up the code again.
29-Vcs-Bzr: http://code.launchpad.net/~unity-team/gnome-control-center-unity/trunk
30+Vcs-Bzr: https://code.launchpad.net/~unity-team/gnome-control-center-unity/trunk
31+Vcs-Browser: https://bazaar.launchpad.net/~unity-team/gnome-control-center-unity/trunk
32
33 Package: gnome-control-center-unity
34 Architecture: any
35-Depends: ${misc:Depends},
36+Depends: gnome-control-center,
37+ ${misc:Depends},
38 ${shlibs:Depends},
39- gnome-control-center,
40 Description: change the settings of the Unity desktop
41 This package contains a settings panel for the Unity desktop,
42 allowing you to set the background and the theme.
43
44=== modified file 'debian/rules'
45--- debian/rules 2013-02-13 14:12:21 +0000
46+++ debian/rules 2013-04-30 00:11:28 +0000
47@@ -1,5 +1,7 @@
48 #!/usr/bin/make -f
49
50+export DPKG_GENSYMBOLS_CHECK_LEVEL=4
51+
52 %:
53 dh $@ --with autoreconf,translations
54
55
56=== removed file 'debian/watch'
57--- debian/watch 2012-11-19 14:30:17 +0000
58+++ debian/watch 1970-01-01 00:00:00 +0000
59@@ -1,2 +0,0 @@
60-version=3
61-http://launchpad.net/gnome-control-center-unity/+download .*/gnome-control-center-unity-(.+)\.tar\.xz

Subscribers

People subscribed via source and target branches

to all changes: