Merge lp:~sil2100/dee/hack_python3_overrides into lp:dee
Status: | Rejected |
---|---|
Rejected by: | Michal Hruby |
Proposed branch: | lp:~sil2100/dee/hack_python3_overrides |
Merge into: | lp:dee |
Diff against target: |
14 lines (+4/-1) 1 file modified
bindings/python3/Makefile.am (+4/-1) |
To merge this branch: | bzr merge lp:~sil2100/dee/hack_python3_overrides |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Disapprove | ||
Review via email: mp+112308@code.launchpad.net |
Commit message
Hard-code the path to python3 gi overrides, since there's no other easy way of doing it in autotools.
Description of the change
The recent addition of python3 overrides has a buggy Makefile. Since because of it, the python3 overrides overwrite the python2 ones, since autotools only sets the path to the first, closest version it finds (2.7 in this case) - and both overrides are installed to the same place.
Since autotools is troublesome, there's no easy way of getting both paths. We would have to add python3 in the build-deps then too. So what I'm doing is hacking the Makefile and hard-coding the python3 path. Ugly, but we just want it installed.
Unmerged revisions
- 369. By Łukasz Zemczak
-
Hard-code the path to python3 gi overrides, since there's no other easy way of doing it in autotools.
The Jenkins job https:/ /jenkins. qa.ubuntu. com/job/ automerge- dee/68/ console reported an error when processing this lp:~sil2100/dee/hack_python3_overrides branch.
Not merging it.