dee

Merge lp:~sil2100/dee/hack_python3_overrides into lp:dee

Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Michal Hruby
Proposed branch: lp:~sil2100/dee/hack_python3_overrides
Merge into: lp:dee
Diff against target: 14 lines (+4/-1)
1 file modified
bindings/python3/Makefile.am (+4/-1)
To merge this branch: bzr merge lp:~sil2100/dee/hack_python3_overrides
Reviewer Review Type Date Requested Status
Michal Hruby (community) Disapprove
Review via email: mp+112308@code.launchpad.net

Commit message

Hard-code the path to python3 gi overrides, since there's no other easy way of doing it in autotools.

Description of the change

The recent addition of python3 overrides has a buggy Makefile. Since because of it, the python3 overrides overwrite the python2 ones, since autotools only sets the path to the first, closest version it finds (2.7 in this case) - and both overrides are installed to the same place.

Since autotools is troublesome, there's no easy way of getting both paths. We would have to add python3 in the build-deps then too. So what I'm doing is hacking the Makefile and hard-coding the python3 path. Ugly, but we just want it installed.

To post a comment you must log in.
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-dee/68/console reported an error when processing this lp:~sil2100/dee/hack_python3_overrides branch.
Not merging it.

Revision history for this message
Michal Hruby (mhr3) wrote :

We can't take that upstream, it will break distcheck and basically every non-distro install.

review: Disapprove
Revision history for this message
Michal Hruby (mhr3) wrote :

Unmerged revisions

369. By Łukasz Zemczak

Hard-code the path to python3 gi overrides, since there's no other easy way of doing it in autotools.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bindings/python3/Makefile.am'
2--- bindings/python3/Makefile.am 2012-05-18 18:38:26 +0000
3+++ bindings/python3/Makefile.am 2012-06-27 10:08:21 +0000
4@@ -1,6 +1,9 @@
5 PLATFORM_VERSION = 3.0
6
7-pkgpyexecdir = $(pyexecdir)/gi
8+# Here we hard-code the python3 path, since we just want to get it installed
9+# and there's no easy way of getting both python2 and python3 patch through
10+# automake
11+pkgpyexecdir = /usr/lib/python3/dist-packages/gi
12
13 pygioverridesdir = $(pkgpyexecdir)/overrides
14 pygioverrides_PYTHON = \

Subscribers

People subscribed via source and target branches

to all changes: